Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise migrations on startup #507

Merged
merged 1 commit into from May 18, 2021

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented May 5, 2021

Related Issue: -

New Behavior

  • Run migrations only when needed
  • Run maintenance tasks after migrations

Contrast to Current Behavior

  • Maintenance tasks are never run in the container

Discussion: Benefits and Drawbacks

Changes to the Wiki

  • None

Proposed Release Note Entry

  • The maintenance tasks that are needed after an update to Netbox are now run automatically

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

The migrations are only started if there are some that have not been
applied. Additionally the maintenace task needed after an update are
now run after the migrations
@ryanmerolle
Copy link
Contributor

This has come up quite a bit on the netbox-docker slack. How can I offer my assistance?

@tobiasge tobiasge mentioned this pull request May 11, 2021
3 tasks
@tobiasge tobiasge requested a review from cimnine May 11, 2021 16:48
@tobiasge tobiasge merged commit 43b8b36 into netbox-community:develop May 18, 2021
@tobiasge tobiasge deleted the run-update-when-needed branch May 18, 2021 06:55
@cimnine cimnine added this to the next milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants