Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unracked devices are labeled "None" #21

Open
llamafilm opened this issue Jun 25, 2024 · 5 comments
Open

Unracked devices are labeled "None" #21

llamafilm opened this issue Jun 25, 2024 · 5 comments

Comments

@llamafilm
Copy link

netbox-reorder-rack version

v1.1.1

Python version

3.12

Steps to Reproduce

  1. Create a new rack
  2. Add 1 or more devices to the rack without a position
  3. Click reorder rack

Expected Behavior

It should show the same label as the /dcim/racks/xxx page and respect the labels vs images preference.

Observed Behavior

All the unracked devices are labeled "None" so it's impossible to identify them
image

@llamafilm
Copy link
Author

After further review, it looks like this issue only happens when the device is unnamed.

@cruse1977
Copy link
Member

Possible requirement for ability to cope with empty device names, however what field could be used as an identifier - ID is obvious but does not help usability; description would be potentially be too long.

@llamafilm
Copy link
Author

For consistent user experience, I would expect this to work the same as other rack elevation views, where it shows the device description.

There is an open FR for custom labels. If this gets implemented, I would hope it applies here too. netbox-community/netbox#14205

@Azmodeszer
Copy link

Azmodeszer commented Jun 27, 2024

NetBox normally shows the Device Type name for unnamed devices in the rack elevation view.

@llamafilm
Copy link
Author

Oops, yes that’s what I meant.

cruse1977 added a commit that referenced this issue Jun 27, 2024
Fixes: #20 - Child Devices should not show as unracked devices
Fixes: #16 - Only Save Devices which have changed face or U position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants