Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Devices allows overlapping rack positions instead of erroring #1232

Closed
HumanEquivalentUnit opened this issue May 26, 2017 · 2 comments
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@HumanEquivalentUnit
Copy link
Contributor

Issue type: bug report

Python version: 2.7.5 (CentOS 7 default)
NetBox version: 2.0.3

  • I configured a device type (HP ProLiant Server) as a 2U device.
  • Imported devices, entered three lines of CSV data, putting them in rack positions 17, 16, 15 (clash!)
  • The import succeeded without errors, and then looking at the rack nothing was rendered in those U positions at all - the imported devices were invisible.

This was a mistake, the servers are actually 1U, and I corrected the device type to 1U and that fixed it, they rendered in the right places.

Expectation: the import would fail because the devices would overlap with each other. Or the rack would render with an error visible in the double-assigned U positions.

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label May 31, 2017
@jeremystretch
Copy link
Member

This is occurring because validation is being performed on each imported device in bulk before the devices are actually created. The bulk import logic is being overwritten in #655, which should resolve this bug once it's completed. Leaving this open for reference.

@jeremystretch
Copy link
Member

This should no longer happen with the new per-object validation implemented as part of #655.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants