Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "# TODO: Remove in v4.0" code #15088

Closed
arthanson opened this issue Feb 8, 2024 · 1 comment
Closed

Remove "# TODO: Remove in v4.0" code #15088

arthanson opened this issue Feb 8, 2024 · 1 comment
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@arthanson
Copy link
Collaborator

arthanson commented Feb 8, 2024 •
edited by DanSheps

Proposed Changes

There are a couple places in the code with "# TODO: Remove in v4.0" tags:

  • netbox/dcim/filtersets.py
  • netbox/utilities/fields.py

Justification

They are already slated to be removed, just a housekeeping task to track removing these.
@arthanson arthanson added the type: housekeeping Changes to the application which do not directly impact the end user label Feb 8, 2024
@arthanson arthanson added this to the v4.0 milestone Feb 8, 2024
@jeremystretch
Copy link
Member

Thanks for calling this out. I've opened #15099 and #15100 to track these individually.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
@jeremystretch jeremystretch removed this from the v4.0 milestone Feb 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arthanson @jeremystretch