Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom link confirmation dialog box #15927

Closed
akshay225063 opened this issue May 2, 2024 · 4 comments
Closed

Custom link confirmation dialog box #15927

akshay225063 opened this issue May 2, 2024 · 4 comments
Labels
status: revisions needed This issue requires additional information to be actionable type: feature Introduction of new functionality to the application

Comments

@akshay225063
Copy link

NetBox version

v3.6.9

Feature type

Change to existing functionality

Proposed functionality

I have created 2 custom links "Block company" and "Unblock company" .
Currently If I click on any of the button then it will do the required operation but I need to add a confirmation dialog before it will do any operation just like we have inbuilt confirmation dialog added for "delete" button.

first_img
second_img

Use case

Currently we only add this feature for delete button where confirmation of the user is required but for other custom links this feature is not implemented.
second_img

Database changes

No response

External dependencies

No response

@akshay225063 akshay225063 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 2, 2024
@jeremystretch
Copy link
Member

Thank you for your interest in extending NetBox. Unfortunately, the information you have provided does not constitute an actionable feature request. Per our contributing guide, a feature request must include a thorough description of the proposed functionality, including any database changes, new views or API endpoints, and so on. It must also include a detailed use case justifying its implementation. If you would like to elaborate on your proposal, please modify your post above. If sufficient detail is not added, this issue will be closed.

@jeremystretch jeremystretch removed their assignment May 2, 2024
@jeremystretch jeremystretch added status: revisions needed This issue requires additional information to be actionable and removed status: needs triage This issue is awaiting triage by a maintainer labels May 2, 2024
@arthanson
Copy link
Collaborator

@akshay225063 can you please expand on what you want here? It sounds like you have added some extra code for the block and unblock but want us to add a custom dialog for it? You can look at the code for the delete confirmation modal and potentially use that for your confirmation modal. Or are you looking for some type of extension mechanism?

@arthanson
Copy link
Collaborator

Closing as no feedback.

@akshay225063
Copy link
Author

akshay225063 commented May 17, 2024

Hello @arthanson
Yes you are correct I have block and unblock code which get executed when custom link block and unblock company clicked.
But when It clicked instead of executing the code user should get custom dialog to confirm
it .
Now I don't know how I can do this integration because for custom links I cannot do any modifications in the code even if I have deleted confirmation modal code but I am not able to implement same with block and unblock custom links.
Note: I have implemented these custom links in Site modal .

Please let me know if any more information required.
Could you please re open the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants