Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): create @skele/core package #112

Merged
merged 6 commits into from
Aug 30, 2018
Merged

feat(core): create @skele/core package #112

merged 6 commits into from
Aug 30, 2018

Conversation

andon
Copy link
Member

@andon andon commented Aug 17, 2018

The @skele/core package contains the following features (usable from all supported environments):

  • data, registry, zip
  • logging internals

It's mostly extracting it from @skele/classic with using it as a dependency in there, while preserving the same API.

More details about the new package restructuring: #99

@andon andon requested review from ognen and bevkoski August 17, 2018 11:56
@coveralls
Copy link

coveralls commented Aug 17, 2018

Pull Request Test Coverage Report for Build 345

  • 27 of 27 (100.0%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.003%) to 78.389%

Totals Coverage Status
Change from base Build 344: 1.003%
Covered Lines: 862
Relevant Lines: 1028

💛 - Coveralls

@andon andon changed the title Create core package feat(core): create @skele/core package Aug 27, 2018
Copy link
Member

@ognen ognen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just, move propNames also into core as the element zipper and various data fns depend on these names.

packages/classic/src/propNames.js Outdated Show resolved Hide resolved
packages/core/src/data/element.js Show resolved Hide resolved
@andon andon merged commit 9979ddf into master Aug 30, 2018
@andon andon deleted the feat/registry-package branch September 1, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants