Merge pull request adobe#17 from adobe/fixIssue16

Fix issue16
netconstructor · Dec 20, 2011 · f55dddd · f55dddd
2 parents 3940eb7 + 74a9c1f
commit f55dddd
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 1 deletion.
diff --git a/bin/mac/Brackets.app/Contents/MacOS/Brackets b/bin/mac/Brackets.app/Contents/MacOS/Brackets
diff --git a/bin/mac/Brackets.app/Contents/MacOS/ffmpegsumo.so b/bin/mac/Brackets.app/Contents/MacOS/ffmpegsumo.so
diff --git a/bin/mac/Brackets.app/Contents/MacOS/libcef.dylib b/bin/mac/Brackets.app/Contents/MacOS/libcef.dylib
diff --git a/bin/mac/Brackets.app/Contents/Resources/brackets_extensions.js b/bin/mac/Brackets.app/Contents/Resources/brackets_extensions.js
@@ -118,6 +118,16 @@ if (!brackets.fs)
     brackets.fs.readdir = function(path, callback) {
         native function ReadDir();
         var resultString = ReadDir(path);
+
+        // File paths can have special characters, so escape them before parsing to JSON
+        resultString = resultString.replace(/\r/g, "\\r")
+                                    .replace(/\n/g, "\\n")
+                                     .replace(/\&/g, "\\&")
+                                    .replace(/\'/g, "\\'")
+                                    .replace(/\t/g, "\\t")
+                                    //.replace(/\b/g, "\\b")  \\ TODO: leaving this in screws up Brackets launch. I don't know why
+                                     .replace(/\f/g, "\\f");
+
         var result = JSON.parse(resultString || '[]');
         callback(getLastError(), result);
     };

diff --git a/src/mac/Resources/brackets_extensions.js b/src/mac/Resources/brackets_extensions.js
@@ -118,7 +118,16 @@ if (!brackets.fs)
     brackets.fs.readdir = function(path, callback) {
         native function ReadDir();
         var resultString = ReadDir(path);
-        console.log( resultString );
+
+        // File paths can have special characters, so escape them before parsing to JSON
+        resultString = resultString.replace(/\r/g, "\\r")
+                                    .replace(/\n/g, "\\n")
+                                     .replace(/\&/g, "\\&")
+                                    .replace(/\'/g, "\\'")
+                                    .replace(/\t/g, "\\t")
+                                    //.replace(/\b/g, "\\b")  \\ TODO: leaving this in screws up Brackets launch. I don't know why
+                                     .replace(/\f/g, "\\f");
+
         var result = JSON.parse(resultString || '[]');
         callback(getLastError(), result);
     };