Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error hitting "Enter" on Filters #172

Open
benloh opened this issue Nov 12, 2021 · 1 comment
Open

Error hitting "Enter" on Filters #172

benloh opened this issue Nov 12, 2021 · 1 comment
Labels
bug Something isn't working
Projects

Comments

@benloh
Copy link
Collaborator

benloh commented Nov 12, 2021

Seems to happen after Login:

  1. Start graph without logging in
  2. Go to log in
  3. Enter a login token
  4. IMPORTANT: Hit "ENTER" to login.
  5. Go to Highlight/Filter
  6. Select Label "contains"
  7. Type something in the field
  8. Hit ENTER
  9. The page reloads.

The error doesn't seem to happen if you don't login using "ENTER" (e.g. if you use the URL)

@benloh benloh created this issue from a note in Version 1.4 (To Do) Nov 12, 2021
@benloh benloh mentioned this issue Nov 12, 2021
@benloh benloh added bug Something isn't working needs_replication labels Nov 12, 2021
@benloh benloh moved this from To Do to In Progress in Version 1.4 Nov 16, 2021
@benloh
Copy link
Collaborator Author

benloh commented Nov 16, 2021

The Node Filters, Edge Filters, Node Filter Transparency, and Edge Filter Transparency are implemented as 4 different forms. Each would accept a "ENTER" as a submit, triggering the page reload.

6e491d5 should fix that by explicitly catching and suppressing the submission.

@benloh benloh moved this from In Progress to In Review in Version 1.4 Nov 16, 2021
@kalanicraig kalanicraig mentioned this issue Nov 19, 2021
6 tasks
@benloh benloh moved this from In Review to Done in Version 1.4 Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant