x509check allow read cert from file (#174)

netdata · Mar 19, 2019 · d1bc033 · d1bc033
1 parent d7b740c
commit d1bc033
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/config/go.d/x509check.conf b/config/go.d/x509check.conf
@@ -53,7 +53,7 @@
 #
 # [ List of JOB specific parameters ]:
 #  - source
-#    Certificate source. Allowed schemes: https, tcp, tcp4, tcp6, udp, udp4, udp6.
+#    Certificate source. Allowed schemes: https, tcp, tcp4, tcp6, udp, udp4, udp6, file.
 #    Syntax:
 #      source: https://example.org:443
 #

diff --git a/modules/x509check/README.md b/modules/x509check/README.md
@@ -21,4 +21,7 @@ jobs:
 
   - name: my_site_org
     source: https://my_site_org:443
+
+  - name: my_local_cert
+    source: file:///home/me/cert.pem
 ```
diff --git a/modules/x509check/cert_getter.go b/modules/x509check/cert_getter.go
@@ -15,7 +15,7 @@ import (
 )
 
 var supportedSchemes = []string{
-	//"file",
+	"file",
 	"https",
 	"tcp",
 	"tcp4",
@@ -37,9 +37,8 @@ func newCertGetter(config Config) (certGetter, error) {
 	}
 
 	switch u.Scheme {
-	// TODO: not tested
-	//case "file":
-	//	return newFileCertGetter(u.Path), nil
+	case "file":
+		return newFileCertGetter(u.Path), nil
 	case "https":
 		u.Scheme = "tcp"
 		fallthrough