This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
weblog: Correctly parse multiple values in nginx upstream_response_time #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the way how the upstream_response_time field is parsed in nginx access logs. The field can contain multiple time values if the request got processed by multiple upstream servers, or if it passed through an internal redirect between multiple server groups (i.e. by using the X-Accel-Redirect header). Previously, only the first encountered value was processed by weblog plugin, and it only accounted for the ',' separator. If the field contained the ':' separator, the value was not parsed correctly. With this commit applied, both of these cases will be handled correctly. Additionaly, the value reported will be the sum of times from all upstream servers that handled the request, i.e. the total time the request spent upstream.
|
Thanks, @kralewitz 👍 |
ilyam8
approved these changes
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way how the upstream_response_time field is
parsed in nginx access logs. The field can contain multiple time values
if the request got processed by multiple upstream servers, or if it
passed through an internal redirect between multiple server groups (i.e.
by using the X-Accel-Redirect header).
Previously, only the first encountered value was processed by weblog
plugin, and it only accounted for the ',' separator. If the field contained
the ':' separator, the value was not parsed correctly. With this commit
applied, both of these cases will be handled correctly. Additionaly, the
value reported will be the sum of times from all upstream servers that
handled the request, i.e. the total time the request spent upstream.