Skip to content

Commit

Permalink
More accurately recreate the environment a user would be building in.
Browse files Browse the repository at this point in the history
We should be testing our distfiles against our current version of
`install-required-packages.sh`, not some pre-generated test image that
we have to manage ina separaterepo.

Also, disable telemetry for the test build so we don't accidentally
pollute the stats.
  • Loading branch information
Ferroin committed Jun 24, 2020
1 parent 11ac102 commit 101ff04
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/scripts/run_install_with_dist_file.sh
Expand Up @@ -19,6 +19,7 @@ shift
printf >&2 "Opening dist archive %s ... " "${distfile}"
tar -xovf "${distfile}"
distdir="$(echo "${distfile}" | cut -d. -f1,2,3)"
cp -a packaging/installer/install-required-packages.sh "${distdir}/install-required-packages.sh"
if [ ! -d "${distdir}" ]; then
printf >&2 "ERROR: %s is not a directory" "${distdir}"
exit 2
Expand All @@ -30,8 +31,8 @@ pushd "${distdir}" || exit 1
docker run \
-v "${PWD}:/netdata" \
-w /netdata \
"netdata/os-test:centos7" \
/bin/bash -c "./netdata-installer.sh --dont-wait --require-cloud --install /tmp && echo \"Validating netdata instance is running\" && wget -O - 'http://127.0.0.1:19999/api/v1/info' | grep version"
"ubuntu:latest" \
/bin/bash -c "./install-required-packages.sh --dont-wait --non-interactive netdata && ./netdata-installer.sh --dont-wait --require-cloud --disable-telemetry --install /tmp && echo \"Validating netdata instance is running\" && wget -O - 'http://127.0.0.1:19999/api/v1/info' | grep version"
popd || exit 1

echo "All Done!"

0 comments on commit 101ff04

Please sign in to comment.