Change the workflow on how we set the right permissions for perf-plug…

…in (#16558)

* Change the workflow on how we set the right permissions

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* Add a failsafe in case fail to set the cap_perfmon

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* add EOF new line

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* Fix workflow

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* minor spelling

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* we made it odyssey

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* Apply suggestion from code review

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>

* Tidy-up postinst script.

---------

Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
Co-authored-by: Austin S. Hemmelgarn <austin@netdata.cloud>
(cherry picked from commit e8a12b3)

contrib/debian/netdata-plugin-perf.postinst

@@ -7,16 +7,10 @@ case "$1" in
     chown root:netdata /usr/libexec/netdata/plugins.d/perf.plugin
     chmod 0750 /usr/libexec/netdata/plugins.d/perf.plugin
 
-    if capsh --supports=cap_perfmon 2>/dev/null; then
-        setcap cap_perfmon+ep /usr/libexec/netdata/plugins.d/perf.plugin
-        ret="$?"
-    else
-        setcap cap_sys_admin+ep /usr/libexec/netdata/plugins.d/perf.plugin
-        ret="$?"
-    fi
-
-    if [ "${ret}" -ne 0 ]; then
-        chmod -f 4750 /usr/libexec/netdata/plugins.d/perf.plugin
+    if ! setcap cap_perfmon+ep /usr/libexec/netdata/plugins.d/perf.plugin 2>/dev/null; then
+        if ! setcap cap_sys_admin+ep /usr/libexec/netdata/plugins.d/perf.plugin 2>/dev/null; then
+            chmod -f 4750 /usr/libexec/netdata/plugins.d/perf.plugin
+        fi
     fi
     ;;
 esac