missing_checks_exporting: cond init

Brings test to uv_cond_init
netdata · May 26, 2020 · 9c445c1 · 9c445c1
1 parent ee1fd6d
commit 9c445c1
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 12 deletions.
diff --git a/exporting/aws_kinesis/aws_kinesis.c b/exporting/aws_kinesis/aws_kinesis.c
@@ -56,9 +56,10 @@ int init_aws_kinesis_instance(struct instance *instance)
         error("EXPORTING: cannot create buffer for AWS Kinesis exporting connector instance %s", instance->config.name);
         return 1;
     }
-    if(uv_mutex_init(&instance->mutex))
+    if (uv_mutex_init(&instance->mutex))
+        return 1;
+    if (uv_cond_init(&instance->cond_var))
         return 1;
-    uv_cond_init(&instance->cond_var);
 
     if (!instance->engine->aws_sdk_initialized) {
         aws_sdk_init();

diff --git a/exporting/graphite/graphite.c b/exporting/graphite/graphite.c
@@ -37,9 +37,10 @@ int init_graphite_instance(struct instance *instance)
         error("EXPORTING: cannot create buffer for graphite exporting connector instance %s", instance->config.name);
         return 1;
     }
-    if(uv_mutex_init(&instance->mutex))
+    if (uv_mutex_init(&instance->mutex))
+        return 1;
+    if (uv_cond_init(&instance->cond_var))
         return 1;
-    uv_cond_init(&instance->cond_var);
 
     return 0;
 }

diff --git a/exporting/json/json.c b/exporting/json/json.c
@@ -37,9 +37,10 @@ int init_json_instance(struct instance *instance)
         error("EXPORTING: cannot create buffer for json exporting connector instance %s", instance->config.name);
         return 1;
     }
-    if(uv_mutex_init(&instance->mutex))
+    if (uv_mutex_init(&instance->mutex))
+        return 1;
+    if (uv_cond_init(&instance->cond_var))
         return 1;
-    uv_cond_init(&instance->cond_var);
 
     return 0;
 }

diff --git a/exporting/opentsdb/opentsdb.c b/exporting/opentsdb/opentsdb.c
@@ -37,9 +37,10 @@ int init_opentsdb_telnet_instance(struct instance *instance)
         error("EXPORTING: cannot create buffer for opentsdb telnet exporting connector instance %s", instance->config.name);
         return 1;
     }
-    if(uv_mutex_init(&instance->mutex))
+    if (uv_mutex_init(&instance->mutex))
+        return 1;
+    if (uv_cond_init(&instance->cond_var))
         return 1;
-    uv_cond_init(&instance->cond_var);
 
     return 0;
 }
@@ -79,9 +80,10 @@ int init_opentsdb_http_instance(struct instance *instance)
         error("EXPORTING: cannot create buffer for opentsdb HTTP exporting connector instance %s", instance->config.name);
         return 1;
     }
-    if(uv_mutex_init(&instance->mutex))
+    if (uv_mutex_init(&instance->mutex))
+        return 1;
+    if (uv_cond_init(&instance->cond_var))
         return 1;
-    uv_cond_init(&instance->cond_var);
 
     return 0;
 }

diff --git a/exporting/prometheus/remote_write/remote_write.c b/exporting/prometheus/remote_write/remote_write.c
@@ -122,9 +122,10 @@ int init_prometheus_remote_write_instance(struct instance *instance)
         error("EXPORTING: cannot create buffer for AWS Kinesis exporting connector instance %s", instance->config.name);
         return 1;
     }
-    if(uv_mutex_init(&instance->mutex))
+    if (uv_mutex_init(&instance->mutex))
+        return 1;
+    if (uv_cond_init(&instance->cond_var))
         return 1;
-    uv_cond_init(&instance->cond_var);
 
     struct prometheus_remote_write_specific_data *connector_specific_data =
         callocz(1, sizeof(struct prometheus_remote_write_specific_data));