-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The source release should include a pre-built configure script #131
Comments
@philwhineray can you review this suggestion please? |
As a comment on this, I just did #132 to add Debian packaging, and added the configure script, but was told to remove it. In projects I work on they are always in git as well - same reasons as noted above. If it's useful, the commit I removed is at https://github.com/mcnewton/netdata/commits/configure-scripts Cheers! |
I forgot to note here the comments on the PR that there are two different locations to download the released version from, which I personally found confusing. Only one includes the configure script. Not enough coffee for me maybe :-) |
I think the releases do contain a configure script. If you obtain the raw
package from version control (I.e github) it does/should not.
For source builds with configure go to https://firehol.org/download/netdata/
where unsigned/master gets built every git checkin. The others contain
official versioned releases which should be where the github releases page
points to.
|
Make it clear the user has got a git version that does not include the configure script. Also has the advantage of publishing the location when browsing the repository. Remove the as part of the build, so that someone who gets a source package with ./configure already does not get confused.
Update README.md to include release URL (#131)
So I have updated the README.md to make things clearer what is going on but I see that the installer script assumes it will run autogen and the install wiki page assumes it is needed too, so some extra work is really required to make it seamless. |
@philwhineray that update to README.md is very useful, thank you. |
This will ensure people get informed about the necessary tools and how to get the package pre-configured without requiring the readme to be modified when packaged. In addition, the script will not run autoreconf unilaterally so when people have an old version it will not attempt to overwrite the pre-existing configure script. Should solve #131 and also #93 as well as recent comments on README.md
Think this can be closed. The installer will point you to the right place if you don't have autotools or too low a version now. |
…#131 Call claim url netdata#4771 Claim ui improvements netdata#4771 Cleanup Implement Sign Out Introduced sign-in modal netdata#3990 Added sign-in button More work on the iframe trick More work More work on the logic, removed old obsolete stuff Close modal Implement account menu Minor rename Renamed my-netdata to My Agents Show migrate button Collect known agents Work on migrateRegistryDidClick Minor Actually show agents from netdata cloud in the menu Some cleanup Keep all the alternate_urls for each agent Fix for tooltips over SignIn/AccountMenu
…#131 Call claim url netdata#4771 Claim ui improvements netdata#4771 Cleanup Implement Sign Out Introduced sign-in modal netdata#3990 Added sign-in button More work on the iframe trick More work More work on the logic, removed old obsolete stuff Close modal Implement account menu Minor rename Renamed my-netdata to My Agents Show migrate button Collect known agents Work on migrateRegistryDidClick Minor Actually show agents from netdata cloud in the menu Some cleanup Keep all the alternate_urls for each agent Fix for tooltips over SignIn/AccountMenu
* Manually merged changes from old hub-support branch, tracking #131 Call claim url #4771 Claim ui improvements #4771 Cleanup Implement Sign Out Introduced sign-in modal #3990 Added sign-in button More work on the iframe trick More work More work on the logic, removed old obsolete stuff Close modal Implement account menu Minor rename Renamed my-netdata to My Agents Show migrate button Collect known agents Work on migrateRegistryDidClick Minor Actually show agents from netdata cloud in the menu Some cleanup Keep all the alternate_urls for each agent Fix for tooltips over SignIn/AccountMenu * Actually use NETDATA.registry.cloudBaseURL Tricky! * Hide switch identity when signed-in #153 * Manually merged changes from old hub-support branch, tracking #131 Call claim url #4771 Claim ui improvements #4771 Cleanup Implement Sign Out Introduced sign-in modal #3990 Added sign-in button More work on the iframe trick More work More work on the logic, removed old obsolete stuff Close modal Implement account menu Minor rename Renamed my-netdata to My Agents Show migrate button Collect known agents Work on migrateRegistryDidClick Minor Actually show agents from netdata cloud in the menu Some cleanup Keep all the alternate_urls for each agent Fix for tooltips over SignIn/AccountMenu * Actually use NETDATA.registry.cloudBaseURL Tricky! * Hide switch identity when signed-in #153 * Cleanup * Refresh menu on sign-in * Disable cloud functionality if cloud base url is not set. This wll allow the merging of the branch into master, so we can avoid nasty rebases. * Updated to use the latest API endpoints * Fixed a couple of LGTM warnings * Improved migration algorithm, some cleanup. * Update My-Netdata menu on sign-out * Minor * Replaced modal with window * Update the My-Agents menu after migration, cleanup * Make the agent work after switching cloudBaseURL, cleanup * Introduced event tracing for analytics * Minor * Removed GA * Fixed error reported by LGTM * Only send the diff when syncing agents to ameliorate the load on the backend, cleanup * Reverted My-Netdata name, added some logging * Add Netdata Cloud menu item * Minor * Use the merge: false option and a fix * Added loading message in my-netdata menu * Show error if we cannot connect to netdata.cloud * Minor * Implemented deleteCloudKnownAgentURL api call, use it in my-netdata menu. * Removed menu entry * Disable my-netdata menu if user is not signed-in and using the global registry * Stop accessing the registry if it's not used. * Mask the agent url if the registry is in 'disabled' mode * Filter masked urls * Improved filtering of masked urls * Try to eagerly initialize the account ui to improve perceived performance * Minor * Don't search for other people's urls in cloud-enabled mode. * Added basic my-netdata filtering * Filter streamed host, aesthetic fixes * Minor * Some improvements of the filter ui * Removed What is this * Added placeholder to input, other fixes #240 * Show message if no databases match filter criteria * Fixed bug where agent lists where not merged * Minor * Hide modal if it redirects to self. * autocomplete off for filter input * Enable delete for custom registries, don't show error if delete fails * Filter agents without urls * Fix LGTM warning * Minor * Concatenate at client side, used the faster merge: false path * Added a clear button to the filter for extra usability * Minor * Minor * Improvements for small screens (more needed) * Combined my-netdata menu and hostname * Re-enabled registry masking * Show agent-filter only when signed-in * Improved syncAgents * Don't mask if using custom registry * Reject agents with empty urls * Filter valid agents * Fixed a couple of bugs * Applied Chris' fixes * Fix in registry.c * Cleanup * Only sync once * Implemented forceSync * Added what is this * sso, wip * Working SSO sign-in/sign-out, cleanup * Added Chris' patch * Added a modal that explains what synchronize is doing * Use sso-agent * Use origin as query param in sign-in * iframe -> origin * Pass machine_guid to sso * Make sure that the current netdata agent is synchronized hub#262 * Normalize originURL * Reenable tryFastInitCloud() * Updated to the latest endpoints * Support synchronizing to multiple cloud accounts * Set default cloud base url to netdata.cloud * Fix filter issues with Firefox * Fix for double tooltip on sign-in * Show known servers in console for debugging purposes * Don't block on errors to delete from registry when signed in * Disable tryFastInitCloud * Improved styling for filter input * Improved styling in my-netdata menu * Display the registry url in the sync-registry modal * agents -> nodes in texts * Support for sso-precheck * Do not implicitly synchronize custom registries. * Improvement to syncAgents (more coming) * More fixes * Don't sign in users with private registries if they don't consent on the sync * Set netdataRegistryAfterMs = 0 * Don't pass url to sso-agent * Added Chris' patch to alarm-notify * Refactored syncAgent/mergeAgents, make sure current Agent is synced on sign-in. * Fix for LGTM warning * Minor * Fix for a XSS warning * Extra check for dataLayer
* Manually merged changes from old hub-support branch, tracking netdata#131 Call claim url netdata#4771 Claim ui improvements netdata#4771 Cleanup Implement Sign Out Introduced sign-in modal netdata#3990 Added sign-in button More work on the iframe trick More work More work on the logic, removed old obsolete stuff Close modal Implement account menu Minor rename Renamed my-netdata to My Agents Show migrate button Collect known agents Work on migrateRegistryDidClick Minor Actually show agents from netdata cloud in the menu Some cleanup Keep all the alternate_urls for each agent Fix for tooltips over SignIn/AccountMenu * Actually use NETDATA.registry.cloudBaseURL Tricky! * Hide switch identity when signed-in netdata#153 * Manually merged changes from old hub-support branch, tracking netdata#131 Call claim url netdata#4771 Claim ui improvements netdata#4771 Cleanup Implement Sign Out Introduced sign-in modal netdata#3990 Added sign-in button More work on the iframe trick More work More work on the logic, removed old obsolete stuff Close modal Implement account menu Minor rename Renamed my-netdata to My Agents Show migrate button Collect known agents Work on migrateRegistryDidClick Minor Actually show agents from netdata cloud in the menu Some cleanup Keep all the alternate_urls for each agent Fix for tooltips over SignIn/AccountMenu * Actually use NETDATA.registry.cloudBaseURL Tricky! * Hide switch identity when signed-in netdata#153 * Cleanup * Refresh menu on sign-in * Disable cloud functionality if cloud base url is not set. This wll allow the merging of the branch into master, so we can avoid nasty rebases. * Updated to use the latest API endpoints * Fixed a couple of LGTM warnings * Improved migration algorithm, some cleanup. * Update My-Netdata menu on sign-out * Minor * Replaced modal with window * Update the My-Agents menu after migration, cleanup * Make the agent work after switching cloudBaseURL, cleanup * Introduced event tracing for analytics * Minor * Removed GA * Fixed error reported by LGTM * Only send the diff when syncing agents to ameliorate the load on the backend, cleanup * Reverted My-Netdata name, added some logging * Add Netdata Cloud menu item * Minor * Use the merge: false option and a fix * Added loading message in my-netdata menu * Show error if we cannot connect to netdata.cloud * Minor * Implemented deleteCloudKnownAgentURL api call, use it in my-netdata menu. * Removed menu entry * Disable my-netdata menu if user is not signed-in and using the global registry * Stop accessing the registry if it's not used. * Mask the agent url if the registry is in 'disabled' mode * Filter masked urls * Improved filtering of masked urls * Try to eagerly initialize the account ui to improve perceived performance * Minor * Don't search for other people's urls in cloud-enabled mode. * Added basic my-netdata filtering * Filter streamed host, aesthetic fixes * Minor * Some improvements of the filter ui * Removed What is this * Added placeholder to input, other fixes netdata#240 * Show message if no databases match filter criteria * Fixed bug where agent lists where not merged * Minor * Hide modal if it redirects to self. * autocomplete off for filter input * Enable delete for custom registries, don't show error if delete fails * Filter agents without urls * Fix LGTM warning * Minor * Concatenate at client side, used the faster merge: false path * Added a clear button to the filter for extra usability * Minor * Minor * Improvements for small screens (more needed) * Combined my-netdata menu and hostname * Re-enabled registry masking * Show agent-filter only when signed-in * Improved syncAgents * Don't mask if using custom registry * Reject agents with empty urls * Filter valid agents * Fixed a couple of bugs * Applied Chris' fixes * Fix in registry.c * Cleanup * Only sync once * Implemented forceSync * Added what is this * sso, wip * Working SSO sign-in/sign-out, cleanup * Added Chris' patch * Added a modal that explains what synchronize is doing * Use sso-agent * Use origin as query param in sign-in * iframe -> origin * Pass machine_guid to sso * Make sure that the current netdata agent is synchronized hub#262 * Normalize originURL * Reenable tryFastInitCloud() * Updated to the latest endpoints * Support synchronizing to multiple cloud accounts * Set default cloud base url to netdata.cloud * Fix filter issues with Firefox * Fix for double tooltip on sign-in * Show known servers in console for debugging purposes * Don't block on errors to delete from registry when signed in * Disable tryFastInitCloud * Improved styling for filter input * Improved styling in my-netdata menu * Display the registry url in the sync-registry modal * agents -> nodes in texts * Support for sso-precheck * Do not implicitly synchronize custom registries. * Improvement to syncAgents (more coming) * More fixes * Don't sign in users with private registries if they don't consent on the sync * Set netdataRegistryAfterMs = 0 * Don't pass url to sso-agent * Added Chris' patch to alarm-notify * Refactored syncAgent/mergeAgents, make sure current Agent is synced on sign-in. * Fix for LGTM warning * Minor * Fix for a XSS warning * Extra check for dataLayer
* Add pkg metrics to support data types benchmark ``` pkg: github.com/netdata/go.d.plugin/pkg/metrics BenchmarkCounter_Add/int-4 2000000000 1.28 ns/op BenchmarkCounter_Add/float-4 1000000000 2.55 ns/op BenchmarkCounter_Inc-4 2000000000 1.54 ns/op BenchmarkCounter_Value-4 2000000000 0.30 ns/op BenchmarkCounter_WriteTo-4 100000000 11.0 ns/op BenchmarkGauge_Add/int-4 1000000000 2.54 ns/op BenchmarkGauge_Add/float-4 1000000000 2.58 ns/op BenchmarkGauge_Inc-4 1000000000 2.57 ns/op BenchmarkGauge_Set-4 2000000000 0.57 ns/op BenchmarkGauge_Value-4 2000000000 0.29 ns/op BenchmarkGauge_WriteTo-4 100000000 10.8 ns/op BenchmarkHistogram_Observe/default-4 200000000 9.05 ns/op BenchmarkHistogram_Observe/len_10-4 200000000 9.30 ns/op BenchmarkHistogram_Observe/len_20-4 100000000 13.8 ns/op BenchmarkHistogram_Observe/len_30-4 50000000 25.0 ns/op BenchmarkHistogram_Observe/len_40-4 50000000 25.0 ns/op BenchmarkHistogram_WriteTo/default-4 500000 2374 ns/op BenchmarkHistogram_WriteTo/len_10-4 1000000 2092 ns/op BenchmarkHistogram_WriteTo/len_20-4 300000 4223 ns/op BenchmarkHistogram_WriteTo/len_30-4 200000 6217 ns/op BenchmarkHistogram_WriteTo/len_40-4 200000 8360 ns/op BenchmarkSummary_Observe-4 1000000000 2.81 ns/op BenchmarkSummary_WriteTo-4 5000000 254 ns/op ``` * fix go mod * fix stm
The
netdata
releases are missing theconfigure
script. It should be pre-built and distributed in the source releases, for the following reasons:netdata
without installing autoconfautogen.sh
doesn’t produce errors, butconfigure
fails withon the other hand, a correctly pre-built
configure
will produce:Note that you can use
./autogen.sh && ./configure && make dist
to generate a source release archive which includes the configure script.The text was updated successfully, but these errors were encountered: