Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The source release should include a pre-built configure script #131

Closed
VinDuv opened this issue Apr 1, 2016 · 7 comments
Closed

The source release should include a pre-built configure script #131

VinDuv opened this issue Apr 1, 2016 · 7 comments
Labels
area/packaging Packaging and operating systems support

Comments

@VinDuv
Copy link

VinDuv commented Apr 1, 2016

The netdata releases are missing the configure script. It should be pre-built and distributed in the source releases, for the following reasons:

  • It allows building netdata without installing autoconf
  • It produces better error messages if something is missing. On a system without pkg-config, autogen.sh doesn’t produce errors, but configure fails with
./configure: line 5030: syntax error near unexpected token `newline'
./configure: line 5030: `   PKG_CHECK_MODULES('

on the other hand, a correctly pre-built configure will produce:

configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config.

Note that you can use ./autogen.sh && ./configure && make dist to generate a source release archive which includes the configure script.

@ktsaou
Copy link
Member

ktsaou commented Apr 1, 2016

@philwhineray can you review this suggestion please?

@mcnewton
Copy link
Contributor

mcnewton commented Apr 1, 2016

As a comment on this, I just did #132 to add Debian packaging, and added the configure script, but was told to remove it. In projects I work on they are always in git as well - same reasons as noted above.

If it's useful, the commit I removed is at https://github.com/mcnewton/netdata/commits/configure-scripts

Cheers!
Matthew

@mcnewton
Copy link
Contributor

mcnewton commented Apr 1, 2016

I forgot to note here the comments on the PR that there are two different locations to download the released version from, which I personally found confusing. Only one includes the configure script. Not enough coffee for me maybe :-)

@ktsaou ktsaou added the area/packaging Packaging and operating systems support label Apr 2, 2016
@philwhineray
Copy link
Contributor

philwhineray commented Apr 2, 2016 via email

philwhineray added a commit that referenced this issue Apr 2, 2016
Make it clear the user has got a git version that does not include
the configure script. Also has the advantage of publishing the location
when browsing the repository.

Remove the as part of the build, so that someone who gets a source
package with ./configure already does not get confused.
philwhineray added a commit that referenced this issue Apr 2, 2016
Update README.md to include release URL (#131)
@philwhineray
Copy link
Contributor

So I have updated the README.md to make things clearer what is going on but I see that the installer script assumes it will run autogen and the install wiki page assumes it is needed too, so some extra work is really required to make it seamless.

@mcnewton
Copy link
Contributor

mcnewton commented Apr 3, 2016

@philwhineray that update to README.md is very useful, thank you.

philwhineray added a commit that referenced this issue Apr 9, 2016
This will ensure people get informed about the necessary tools and
how to get the package pre-configured without requiring the readme
to be modified when packaged.

In addition, the script will not run autoreconf unilaterally so when
people have an old version it will not attempt to overwrite the
pre-existing configure script.

Should solve #131 and also #93 as well as recent comments on README.md
@philwhineray
Copy link
Contributor

Think this can be closed. The installer will point you to the right place if you don't have autotools or too low a version now.

gmosx pushed a commit to gmosx/netdata that referenced this issue Dec 13, 2018
…#131

Call claim url netdata#4771
Claim ui improvements netdata#4771
Cleanup
Implement Sign Out
Introduced sign-in modal netdata#3990
Added sign-in button
More work on the iframe trick
More work
More work on the logic, removed old obsolete stuff
Close modal
Implement account menu
Minor rename
Renamed my-netdata to My Agents
Show migrate button
Collect known agents
Work on migrateRegistryDidClick
Minor
Actually show agents from netdata cloud in the menu
Some cleanup
Keep all the alternate_urls for each agent
Fix for tooltips over SignIn/AccountMenu
gmosx pushed a commit to gmosx/netdata that referenced this issue Dec 13, 2018
…#131

Call claim url netdata#4771
Claim ui improvements netdata#4771
Cleanup
Implement Sign Out
Introduced sign-in modal netdata#3990
Added sign-in button
More work on the iframe trick
More work
More work on the logic, removed old obsolete stuff
Close modal
Implement account menu
Minor rename
Renamed my-netdata to My Agents
Show migrate button
Collect known agents
Work on migrateRegistryDidClick
Minor
Actually show agents from netdata cloud in the menu
Some cleanup
Keep all the alternate_urls for each agent
Fix for tooltips over SignIn/AccountMenu
gmosx added a commit that referenced this issue Jan 28, 2019
* Manually merged changes from old hub-support branch, tracking #131

Call claim url #4771
Claim ui improvements #4771
Cleanup
Implement Sign Out
Introduced sign-in modal #3990
Added sign-in button
More work on the iframe trick
More work
More work on the logic, removed old obsolete stuff
Close modal
Implement account menu
Minor rename
Renamed my-netdata to My Agents
Show migrate button
Collect known agents
Work on migrateRegistryDidClick
Minor
Actually show agents from netdata cloud in the menu
Some cleanup
Keep all the alternate_urls for each agent
Fix for tooltips over SignIn/AccountMenu

* Actually use NETDATA.registry.cloudBaseURL

Tricky!

* Hide switch identity when signed-in #153

* Manually merged changes from old hub-support branch, tracking #131

Call claim url #4771
Claim ui improvements #4771
Cleanup
Implement Sign Out
Introduced sign-in modal #3990
Added sign-in button
More work on the iframe trick
More work
More work on the logic, removed old obsolete stuff
Close modal
Implement account menu
Minor rename
Renamed my-netdata to My Agents
Show migrate button
Collect known agents
Work on migrateRegistryDidClick
Minor
Actually show agents from netdata cloud in the menu
Some cleanup
Keep all the alternate_urls for each agent
Fix for tooltips over SignIn/AccountMenu

* Actually use NETDATA.registry.cloudBaseURL

Tricky!

* Hide switch identity when signed-in #153

* Cleanup

* Refresh menu on sign-in

* Disable cloud functionality if cloud base url is not set.

This wll allow the merging of the branch into master, so we can avoid nasty rebases.

* Updated to use the latest API endpoints

* Fixed a couple of LGTM warnings

* Improved migration algorithm, some cleanup.

* Update My-Netdata menu on sign-out

* Minor

* Replaced modal with window

* Update the My-Agents menu after migration, cleanup

* Make the agent work after switching cloudBaseURL, cleanup

* Introduced event tracing for analytics

* Minor

* Removed GA

* Fixed error reported by LGTM

* Only send the diff when syncing agents to ameliorate the load on the backend, cleanup

* Reverted My-Netdata name, added some logging

* Add Netdata Cloud menu item

* Minor

* Use the merge: false option and a fix

* Added loading message in my-netdata menu

* Show error if we cannot connect to netdata.cloud

* Minor

* Implemented deleteCloudKnownAgentURL api call, use it in my-netdata menu.

* Removed menu entry

* Disable my-netdata menu if user is not signed-in and using the global registry

* Stop accessing the registry if it's not used.

* Mask the agent url if the registry is in 'disabled' mode

* Filter masked urls

* Improved filtering of masked urls

* Try to eagerly initialize the account ui to improve perceived performance

* Minor

* Don't search for other people's urls in cloud-enabled mode.

* Added basic my-netdata filtering

* Filter streamed host, aesthetic fixes

* Minor

* Some improvements of the filter ui

* Removed What is this

* Added placeholder to input, other fixes #240

* Show message if no databases match filter criteria

* Fixed bug where agent lists where not merged

* Minor

* Hide modal if it redirects to self.

* autocomplete off for filter input

* Enable delete for custom registries, don't show error if delete fails

* Filter agents without urls

* Fix LGTM warning

* Minor

* Concatenate at client side, used the faster merge: false path

* Added a clear button to the filter for extra usability

* Minor

* Minor

* Improvements for small screens (more needed)

* Combined  my-netdata menu and hostname

* Re-enabled registry masking

* Show agent-filter only when signed-in

* Improved syncAgents

* Don't mask if using custom registry

* Reject agents with empty urls

* Filter valid agents

* Fixed a couple of bugs

* Applied Chris' fixes

* Fix in registry.c

* Cleanup

* Only sync once

* Implemented forceSync

* Added what is this

* sso, wip

* Working SSO sign-in/sign-out, cleanup

* Added Chris' patch

* Added a modal that explains what synchronize is doing

* Use sso-agent

* Use origin as query param in sign-in

* iframe -> origin

* Pass machine_guid to sso

* Make sure that the current netdata agent is synchronized hub#262

* Normalize originURL

* Reenable tryFastInitCloud()

* Updated to the latest endpoints

* Support synchronizing to multiple cloud accounts

* Set default cloud base url to netdata.cloud

* Fix filter issues with Firefox

* Fix for double tooltip on sign-in

* Show known servers in console for debugging purposes

* Don't block on errors to delete from registry when signed in

* Disable tryFastInitCloud

* Improved styling for filter input

* Improved styling in my-netdata menu

* Display the registry url in the sync-registry modal

* agents -> nodes in texts

* Support for sso-precheck

* Do not implicitly synchronize custom registries.

* Improvement to syncAgents (more coming)

* More fixes

* Don't sign in users with private registries if they don't consent on the sync

* Set netdataRegistryAfterMs = 0

* Don't pass url to sso-agent

* Added Chris' patch to alarm-notify

* Refactored syncAgent/mergeAgents, make sure current Agent is synced on sign-in.

* Fix for LGTM warning

* Minor

* Fix for a XSS warning

* Extra check for dataLayer
kiku-jw pushed a commit to kiku-jw/netdata that referenced this issue Mar 4, 2019
* Manually merged changes from old hub-support branch, tracking netdata#131

Call claim url netdata#4771
Claim ui improvements netdata#4771
Cleanup
Implement Sign Out
Introduced sign-in modal netdata#3990
Added sign-in button
More work on the iframe trick
More work
More work on the logic, removed old obsolete stuff
Close modal
Implement account menu
Minor rename
Renamed my-netdata to My Agents
Show migrate button
Collect known agents
Work on migrateRegistryDidClick
Minor
Actually show agents from netdata cloud in the menu
Some cleanup
Keep all the alternate_urls for each agent
Fix for tooltips over SignIn/AccountMenu

* Actually use NETDATA.registry.cloudBaseURL

Tricky!

* Hide switch identity when signed-in netdata#153

* Manually merged changes from old hub-support branch, tracking netdata#131

Call claim url netdata#4771
Claim ui improvements netdata#4771
Cleanup
Implement Sign Out
Introduced sign-in modal netdata#3990
Added sign-in button
More work on the iframe trick
More work
More work on the logic, removed old obsolete stuff
Close modal
Implement account menu
Minor rename
Renamed my-netdata to My Agents
Show migrate button
Collect known agents
Work on migrateRegistryDidClick
Minor
Actually show agents from netdata cloud in the menu
Some cleanup
Keep all the alternate_urls for each agent
Fix for tooltips over SignIn/AccountMenu

* Actually use NETDATA.registry.cloudBaseURL

Tricky!

* Hide switch identity when signed-in netdata#153

* Cleanup

* Refresh menu on sign-in

* Disable cloud functionality if cloud base url is not set.

This wll allow the merging of the branch into master, so we can avoid nasty rebases.

* Updated to use the latest API endpoints

* Fixed a couple of LGTM warnings

* Improved migration algorithm, some cleanup.

* Update My-Netdata menu on sign-out

* Minor

* Replaced modal with window

* Update the My-Agents menu after migration, cleanup

* Make the agent work after switching cloudBaseURL, cleanup

* Introduced event tracing for analytics

* Minor

* Removed GA

* Fixed error reported by LGTM

* Only send the diff when syncing agents to ameliorate the load on the backend, cleanup

* Reverted My-Netdata name, added some logging

* Add Netdata Cloud menu item

* Minor

* Use the merge: false option and a fix

* Added loading message in my-netdata menu

* Show error if we cannot connect to netdata.cloud

* Minor

* Implemented deleteCloudKnownAgentURL api call, use it in my-netdata menu.

* Removed menu entry

* Disable my-netdata menu if user is not signed-in and using the global registry

* Stop accessing the registry if it's not used.

* Mask the agent url if the registry is in 'disabled' mode

* Filter masked urls

* Improved filtering of masked urls

* Try to eagerly initialize the account ui to improve perceived performance

* Minor

* Don't search for other people's urls in cloud-enabled mode.

* Added basic my-netdata filtering

* Filter streamed host, aesthetic fixes

* Minor

* Some improvements of the filter ui

* Removed What is this

* Added placeholder to input, other fixes netdata#240

* Show message if no databases match filter criteria

* Fixed bug where agent lists where not merged

* Minor

* Hide modal if it redirects to self.

* autocomplete off for filter input

* Enable delete for custom registries, don't show error if delete fails

* Filter agents without urls

* Fix LGTM warning

* Minor

* Concatenate at client side, used the faster merge: false path

* Added a clear button to the filter for extra usability

* Minor

* Minor

* Improvements for small screens (more needed)

* Combined  my-netdata menu and hostname

* Re-enabled registry masking

* Show agent-filter only when signed-in

* Improved syncAgents

* Don't mask if using custom registry

* Reject agents with empty urls

* Filter valid agents

* Fixed a couple of bugs

* Applied Chris' fixes

* Fix in registry.c

* Cleanup

* Only sync once

* Implemented forceSync

* Added what is this

* sso, wip

* Working SSO sign-in/sign-out, cleanup

* Added Chris' patch

* Added a modal that explains what synchronize is doing

* Use sso-agent

* Use origin as query param in sign-in

* iframe -> origin

* Pass machine_guid to sso

* Make sure that the current netdata agent is synchronized hub#262

* Normalize originURL

* Reenable tryFastInitCloud()

* Updated to the latest endpoints

* Support synchronizing to multiple cloud accounts

* Set default cloud base url to netdata.cloud

* Fix filter issues with Firefox

* Fix for double tooltip on sign-in

* Show known servers in console for debugging purposes

* Don't block on errors to delete from registry when signed in

* Disable tryFastInitCloud

* Improved styling for filter input

* Improved styling in my-netdata menu

* Display the registry url in the sync-registry modal

* agents -> nodes in texts

* Support for sso-precheck

* Do not implicitly synchronize custom registries.

* Improvement to syncAgents (more coming)

* More fixes

* Don't sign in users with private registries if they don't consent on the sync

* Set netdataRegistryAfterMs = 0

* Don't pass url to sso-agent

* Added Chris' patch to alarm-notify

* Refactored syncAgent/mergeAgents, make sure current Agent is synced on sign-in.

* Fix for LGTM warning

* Minor

* Fix for a XSS warning

* Extra check for dataLayer
stelfrag added a commit that referenced this issue Aug 16, 2021
vkalintiris pushed a commit to vkalintiris/netdata that referenced this issue Dec 13, 2023
* Add pkg metrics to support data types

benchmark
```
pkg: github.com/netdata/go.d.plugin/pkg/metrics
BenchmarkCounter_Add/int-4     	              2000000000	         1.28 ns/op
BenchmarkCounter_Add/float-4   	              1000000000	         2.55 ns/op
BenchmarkCounter_Inc-4         	              2000000000	         1.54 ns/op
BenchmarkCounter_Value-4       	              2000000000	         0.30 ns/op
BenchmarkCounter_WriteTo-4     	              100000000	                 11.0 ns/op
BenchmarkGauge_Add/int-4       	              1000000000	         2.54 ns/op
BenchmarkGauge_Add/float-4     	              1000000000	         2.58 ns/op
BenchmarkGauge_Inc-4           	              1000000000	         2.57 ns/op
BenchmarkGauge_Set-4           	              2000000000	         0.57 ns/op
BenchmarkGauge_Value-4         	              2000000000	         0.29 ns/op
BenchmarkGauge_WriteTo-4       	              100000000	                 10.8 ns/op
BenchmarkHistogram_Observe/default-4         	200000000	         9.05 ns/op
BenchmarkHistogram_Observe/len_10-4          	200000000	         9.30 ns/op
BenchmarkHistogram_Observe/len_20-4          	100000000	        13.8 ns/op
BenchmarkHistogram_Observe/len_30-4          	50000000	        25.0 ns/op
BenchmarkHistogram_Observe/len_40-4          	50000000	        25.0 ns/op
BenchmarkHistogram_WriteTo/default-4         	  500000	      2374 ns/op
BenchmarkHistogram_WriteTo/len_10-4          	 1000000	      2092 ns/op
BenchmarkHistogram_WriteTo/len_20-4          	  300000	      4223 ns/op
BenchmarkHistogram_WriteTo/len_30-4          	  200000	      6217 ns/op
BenchmarkHistogram_WriteTo/len_40-4          	  200000	      8360 ns/op
BenchmarkSummary_Observe-4                   	1000000000	         2.81 ns/op
BenchmarkSummary_WriteTo-4                   	 5000000	       254 ns/op
```

* fix go mod

* fix stm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

No branches or pull requests

4 participants