Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugfs collector #15017

Merged
merged 89 commits into from
May 15, 2023
Merged

Debugfs collector #15017

merged 89 commits into from
May 15, 2023

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented May 5, 2023

Summary

Fixes #15001
Fixes #14927

Test Plan
  1. Mount debugfs if it nos mounted:
# mount -t debugfs nodev /sys/kernel/debug
  1. Enable zswap:
# echo 1 > /sys/module/zswap/parameters/enabled
  1. Compile branch and check metrics. You can compare values on dashboard with file values running:
# find /sys/kernel/debug/zswap/ -type f -exec grep -H . {} \;
# cat /sys/kernel/debug/extfrag/extfrag_index
Additional Information

As we define in our meeting today, the PR with alerts will be a separated PR, because I had to address 19 files in this PR.

For users: How does this change affect me? Describe the PR affects users: - Which area of Netdata is affected by the change? plugins - Can they see the change or is it an under the hood? If they can see it, where? Yes, after to be merged users will be another plugin running when `debugfs` is mounted. - How is the user impacted by the change? More information about memory - What are there any benefits of the change? We will have more metrics helping to understand better memory on host.

@thiagoftsm thiagoftsm marked this pull request as draft May 5, 2023 01:48
@github-actions github-actions bot added area/build Build system (autotools and cmake). area/collectors Everything related to data collection area/docs area/packaging Packaging and operating systems support labels May 5, 2023
Copy link
Member

@Ferroin Ferroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need handling in our packaging code, and the static builds, but I can take care of that shortly before we merge it if desired (I’m hesitant to do any of it any sooner as we have a lot of things changing in those areas in the very near future).

@thiagoftsm
Copy link
Contributor Author

Thank you @Ferroin !
In this first stage I only modified autoconf to have conditions to develop, as soon collector is ready, I will ping you. 🤝

netdata-installer.sh Outdated Show resolved Hide resolved
Copy link
Member

@Ancairon Ancairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight docs change, the rest lgtm

collectors/debugfs.plugin/README.md Outdated Show resolved Hide resolved
ilyam8
ilyam8 previously approved these changes May 15, 2023
Copy link
Member

@Ferroin Ferroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggested changes, but otherwise LGTM.

collectors/debugfs.plugin/README.md Outdated Show resolved Hide resolved
netdata-installer.sh Show resolved Hide resolved
Co-authored-by: Austin S. Hemmelgarn <ahferroin7@gmail.com>
Ferroin
Ferroin previously approved these changes May 15, 2023
@ilyam8 ilyam8 merged commit 588096c into netdata:master May 15, 2023
@thiagoftsm thiagoftsm deleted the debugfs_collector branch May 15, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build system (autotools and cmake). area/ci area/collectors Everything related to data collection area/daemon area/docs area/packaging Packaging and operating systems support area/web collectors/apps collectors/ebpf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add support for collecting metrics from debugfs [Feat]: zswap monitoring
5 participants