-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugfs collector #15017
Debugfs collector #15017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also need handling in our packaging code, and the static builds, but I can take care of that shortly before we merge it if desired (I’m hesitant to do any of it any sooner as we have a lot of things changing in those areas in the very near future).
Thank you @Ferroin ! |
…t will be used to parse new file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight docs change, the rest lgtm
Co-authored-by: Fotis Voutsas <fotis@netdata.cloud>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggested changes, but otherwise LGTM.
Co-authored-by: Austin S. Hemmelgarn <ahferroin7@gmail.com>
Summary
Fixes #15001
Fixes #14927
Test Plan
debugfs
if it nos mounted:# mount -t debugfs nodev /sys/kernel/debug
zswap
:# echo 1 > /sys/module/zswap/parameters/enabled
Additional Information
As we define in our meeting today, the PR with alerts will be a separated PR, because I had to address 19 files in this PR.
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? plugins - Can they see the change or is it an under the hood? If they can see it, where? Yes, after to be merged users will be another plugin running when `debugfs` is mounted. - How is the user impacted by the change? More information about memory - What are there any benefits of the change? We will have more metrics helping to understand better memory on host.