apps.plugin is not installed

[ktsaou]

@alonbl when I install it in some cases I have this:

make install

Making install in charts.d
make[1]: Entering directory '/opt/netdata.git/charts.d'
make[2]: Entering directory '/opt/netdata.git/charts.d'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/usr/libexec/netdata/charts.d'
 /usr/bin/install -c airsearches.chart.sh cpu_apps.chart.sh cpufreq.chart.sh crsproxy.chart.sh example.chart.sh load_average.chart.sh mem_apps.chart.sh mysql.chart.sh nut.chart.sh opensips.chart.sh postfix.chart.sh sensors.chart.sh squid.chart.sh '/usr/libexec/netdata/charts.d'
make[2]: Leaving directory '/opt/netdata.git/charts.d'
make[1]: Leaving directory '/opt/netdata.git/charts.d'
Making install in conf.d
make[1]: Entering directory '/opt/netdata.git/conf.d'
make[2]: Entering directory '/opt/netdata.git/conf.d'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/etc/netdata'
 /usr/bin/install -c -m 644 apps_groups.conf '/etc/netdata'
make[2]: Leaving directory '/opt/netdata.git/conf.d'
make[1]: Leaving directory '/opt/netdata.git/conf.d'
Making install in plugins.d
make[1]: Entering directory '/opt/netdata.git/plugins.d'
make[2]: Entering directory '/opt/netdata.git/plugins.d'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/usr/libexec/netdata/plugins.d'
 /usr/bin/install -c -m 644 README loopsleepms.sh.inc '/usr/libexec/netdata/plugins.d'
 /bin/mkdir -p '/usr/libexec/netdata/plugins.d'
 /usr/bin/install -c charts.d.dryrun-helper.sh charts.d.plugin tc-qos-helper.sh '/usr/libexec/netdata/plugins.d'
make[2]: Leaving directory '/opt/netdata.git/plugins.d'
make[1]: Leaving directory '/opt/netdata.git/plugins.d'
Making install in src
make[1]: Entering directory '/opt/netdata.git/src'
make[2]: Entering directory '/opt/netdata.git/src'
 /bin/mkdir -p '/usr/bin'
  /usr/bin/install -c netdata '/usr/bin'
make  install-exec-hook
make[3]: Entering directory '/opt/netdata.git/src'
if [ `id -u` == 0 ]; then \
        chown root '/usr/libexec/netdata/plugins.d/apps.plugin' && \
                chmod 4755 '/usr/libexec/netdata/plugins.d/apps.plugin'; \
else \
        echo; \
        echo "ATTENTION"; \
        echo; \
        echo "setuid bit of /usr/libexec/netdata/plugins.d/apps.plugin must be set, please execute as root:"; \
        echo "chown root '/usr/libexec/netdata/plugins.d/apps.plugin' && chmod 4755 '/usr/libexec/netdata/plugins.d/apps.plugin'"; \
        echo; \
fi
chown: cannot access '/usr/libexec/netdata/plugins.d/apps.plugin': No such file or directory
Makefile:845: recipe for target 'install-exec-hook' failed
make[3]: *** [install-exec-hook] Error 1
make[3]: Leaving directory '/opt/netdata.git/src'
Makefile:782: recipe for target 'install-exec-am' failed
make[2]: *** [install-exec-am] Error 2
make[2]: Leaving directory '/opt/netdata.git/src'
Makefile:726: recipe for target 'install-am' failed
make[1]: *** [install-am] Error 2
make[1]: Leaving directory '/opt/netdata.git/src'
Makefile:413: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1

It does not install apps.plugin, although it is build.
This log is from a current OSMC installation (raspbian based I think).

[ktsaou]

This is from a successful install:

Making install in charts.d
make[1]: Entering directory '/data/src/netdata.git/charts.d'
make[2]: Entering directory '/data/src/netdata.git/charts.d'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/usr/libexec/netdata/charts.d'
 /usr/bin/install -c airsearches.chart.sh cpu_apps.chart.sh cpufreq.chart.sh crsproxy.chart.sh example.chart.sh load_average.chart.sh mem_apps.chart.sh mysql.chart.sh nut.chart.sh opensips.chart.sh postfix.chart.sh sensors.chart.sh squid.chart.sh '/usr/libexec/netdata/charts.d'
make[2]: Leaving directory '/data/src/netdata.git/charts.d'
make[1]: Leaving directory '/data/src/netdata.git/charts.d'
Making install in conf.d
make[1]: Entering directory '/data/src/netdata.git/conf.d'
make[2]: Entering directory '/data/src/netdata.git/conf.d'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/etc/netdata'
 /usr/bin/install -c -m 644 apps_groups.conf '/etc/netdata'
make[2]: Leaving directory '/data/src/netdata.git/conf.d'
make[1]: Leaving directory '/data/src/netdata.git/conf.d'
Making install in plugins.d
make[1]: Entering directory '/data/src/netdata.git/plugins.d'
make[2]: Entering directory '/data/src/netdata.git/plugins.d'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/usr/libexec/netdata/plugins.d'
 /usr/bin/install -c -m 644 README loopsleepms.sh.inc '/usr/libexec/netdata/plugins.d'
 /bin/mkdir -p '/usr/libexec/netdata/plugins.d'
 /usr/bin/install -c charts.d.dryrun-helper.sh charts.d.plugin tc-qos-helper.sh '/usr/libexec/netdata/plugins.d'
make[2]: Leaving directory '/data/src/netdata.git/plugins.d'
make[1]: Leaving directory '/data/src/netdata.git/plugins.d'
Making install in src
make[1]: Entering directory '/data/src/netdata.git/src'
make[2]: Entering directory '/data/src/netdata.git/src'
 /bin/mkdir -p '/usr/bin'
  /usr/bin/install -c netdata '/usr/bin'
make  install-exec-hook
make[3]: Entering directory '/data/src/netdata.git/src'
if [ `id -u` == 0 ]; then \
        chown root '/usr/libexec/netdata/plugins.d/apps.plugin' && \
                chmod 4755 '/usr/libexec/netdata/plugins.d/apps.plugin'; \
else \
        echo; \
        echo "ATTENTION"; \
        echo; \
        echo "setuid bit of /usr/libexec/netdata/plugins.d/apps.plugin must be set, please execute as root:"; \
        echo "chown root '/usr/libexec/netdata/plugins.d/apps.plugin' && chmod 4755 '/usr/libexec/netdata/plugins.d/apps.plugin'"; \
        echo; \
fi
make[3]: Leaving directory '/data/src/netdata.git/src'
 /bin/mkdir -p '/var/cache/netdata'
 /usr/bin/install -c -m 644 .keep '/var/cache/netdata'
 /bin/mkdir -p '/var/log/netdata'
 /usr/bin/install -c -m 644 .keep '/var/log/netdata'
 /bin/mkdir -p '/usr/libexec/netdata/plugins.d'
  /usr/bin/install -c apps.plugin '/usr/libexec/netdata/plugins.d'
make[2]: Leaving directory '/data/src/netdata.git/src'
make[1]: Leaving directory '/data/src/netdata.git/src'
Making install in web
make[1]: Entering directory '/data/src/netdata.git/web'
make[2]: Entering directory '/data/src/netdata.git/web'
make[2]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p '/usr/share/netdata/web'
 /usr/bin/install -c -m 644 datasource.html index.html index.js netdata.js robots.txt theme.css '/usr/share/netdata/web'
make[2]: Leaving directory '/data/src/netdata.git/web'
make[1]: Leaving directory '/data/src/netdata.git/web'
make[1]: Entering directory '/data/src/netdata.git'
make[2]: Entering directory '/data/src/netdata.git'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/data/src/netdata.git'
make[1]: Leaving directory '/data/src/netdata.git'

As I see it, it tries to chown, chmod apps.plugin before it is installed.

[alonbl]

Checkout #27