Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc.plugin: use high-precission bash sleep as loadable #5161

Closed
paulfantom opened this issue Jan 13, 2019 · 1 comment
Closed

tc.plugin: use high-precission bash sleep as loadable #5161

paulfantom opened this issue Jan 13, 2019 · 1 comment
Assignees
@paulfantom
Labels
area/collectors Everything related to data collection
Milestone
v1.13-rc1

Comments

@paulfantom
Copy link
Contributor

Feature idea summary

Remove loopsleepms.sh.inc and replace it with a loadable high-precision sleep implementation. Implementation is available for bash >= 4.4 and can be easily loaded with:

[ -z "$BASH_LOADABLES_PATH" ] &&
  BASH_LOADABLES_PATH=$(pkg-config bash --variable=loadablesdir 2>/dev/null)  
enable -f sleep sleep
Expected behavior

Cleaner codebase which uses build-in higher precision implementations
@paulfantom paulfantom added the area/collectors Everything related to data collection label Jan 13, 2019
@paulfantom paulfantom added this to the v1.13-rc0 milestone Jan 13, 2019
@paulfantom paulfantom self-assigned this Jan 13, 2019
@paulfantom paulfantom mentioned this issue Jan 13, 2019
Merged
@cakrit cakrit modified the milestones: v1.12, v1.13-rc0 Jan 31, 2019
@paulfantom paulfantom mentioned this issue Feb 12, 2019
Closed
@cakrit cakrit modified the milestones: v1.13-rc0, v1.13-rc1 Feb 14, 2019
@paulfantom
Copy link
Contributor Author

Not going to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulfantom paulfantom

Labels
area/collectors Everything related to data collection
Projects
None yet
Milestone
v1.13-rc1
Development

Successfully merging a pull request may close this issue.

replace loopsleepms with bash loadable
2 participants
@paulfantom @cakrit