Lint tc-qos-helper.sh.in #5163
Merged
Lint tc-qos-helper.sh.in #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2019
Merged
Merged
paulfantom
added
the
no changelog
ktsaou
approved these changes
Jan 14, 2019
kiku-jw
pushed a commit
to kiku-jw/netdata
that referenced
this pull request
Mar 4, 2019
* lint tc-qos-helper script * run automatic formatter on tc-qos-helper script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unfortunately codacy doesn't check for code quality in this file due to wrong file extension. So I did it manually.
Revising this script spawned also issue #5161.
Component Name
tc plugin collector
Additional Information
To allow easier code review changes are commited in two parts:
shfmt(second commit)Part of larger effort to cleanup bash scripts with file extension ending in
.sh.in.More in following PRs:
#5162
#5163
#5164
#5165