Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install-required-packages script to self-update apt #8491

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Fix install-required-packages script to self-update apt #8491

merged 2 commits into from
Mar 25, 2020

Conversation

prologic
Copy link
Contributor

Summary

As per our title.

Also fixes (hopefully) breaking CI checks I'm seeing in various PR(s).

e.g: #8485

Component Name
  • area/ci
  • area/packaging
Test Plan

Our CI will test this change across many systems and the breakages I'm seeing
which I reported in actions/runner-images#624 automatically get resolved.

Additional Information

I believe this is the root cause of why our CI would sometimes fail.
We would not update the apt cachce when installing extra things we need
in CI which runs on Ubuntu bionic.

If this works @al-cheb I apologize for the noise and actions/runner-images#624
can probably be closed :)

… update on systems (almost every other package manager self-updates anyway)
@squash-labs
Copy link

squash-labs bot commented Mar 25, 2020

Manage this branch in Squash

Test this branch here: https://prologicauto-update-apt-mrgbd.squash.io

@prologic prologic changed the title Fix our install-required-packages script to automatically run apt-get update on systems (almost every other package manager self-updates anyway) Fix our install-required-packages script to automatically run apt-get update on systems Mar 25, 2020
@prologic prologic changed the title Fix our install-required-packages script to automatically run apt-get update on systems Fix our install-required-packages script to self-updated apt caches Mar 25, 2020
@prologic prologic changed the title Fix our install-required-packages script to self-updated apt caches Fix install-required-packages script to self-update apt Mar 25, 2020
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Mar 25, 2020
Ferroin
Ferroin previously approved these changes Mar 25, 2020
@prologic prologic requested a review from Ferroin March 25, 2020 21:56
@prologic prologic merged commit e6c7dfa into netdata:master Mar 25, 2020
@prologic prologic deleted the auto_update_apt branch March 25, 2020 22:23
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
* Fix our install-required-packages script to automatically run apt-get update on systems (almost every other package manager self-updates anyway)

* Add -o Acquire::Check-Valid-Until=false for Debian 8 (jessie)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants