Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings in the claiming code #8567

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix compiler warnings in the claiming code #8567

merged 2 commits into from
Apr 3, 2020

Conversation

vlvkobal
Copy link
Contributor

@vlvkobal vlvkobal commented Apr 1, 2020

Summary

When the --disable-cloud option is used to build Netdata there are compiler warnings

claim/claim.c: In function 'claim_agent':
claim/claim.c:42:24: warning: unused parameter 'claiming_arguments' [-Wunused-parameter]
   42 | void claim_agent(char *claiming_arguments)
      |                  ~~~~~~^~~~~~~~~~~~~~~~~~
At top level:
claim/claim.c:9:14: warning: 'claiming_errors' defined but not used [-Wunused-variable]
    9 | static char *claiming_errors[] = {
      |
Component Name

cloud

Test Plan

Run sudo ./netdata-installer.sh --disable-cloud.

@squash-labs
Copy link

squash-labs bot commented Apr 1, 2020

Manage this branch in Squash

Test this branch here: https://vlvkobalfix-climing-warnings-r7m0g.squash.io

@vlvkobal vlvkobal force-pushed the fix-climing-warnings branch 2 times, most recently from e9cca23 to 1732f8e Compare April 1, 2020 09:57
@vlvkobal vlvkobal mentioned this pull request Apr 1, 2020
Closed
@vlvkobal vlvkobal changed the title Fix compiler warnings in the climing code Fix compiler warnings in the claiming code Apr 1, 2020
@vlvkobal vlvkobal marked this pull request as ready for review April 1, 2020 12:23
@vlvkobal vlvkobal requested review from amoss and underhood April 1, 2020 12:23
@vlvkobal vlvkobal added area/build Build system (autotools and cmake). cloud Netdata hub/cloud related labels Apr 1, 2020
underhood
underhood reviewed Apr 1, 2020
View reviewed changes
claim/claim.c Outdated Show resolved Hide resolved
underhood
underhood suggested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@underhood underhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use UNUSED macro for that now

@vlvkobal vlvkobal merged commit c7d8aec into netdata:master Apr 3, 2020
@vlvkobal vlvkobal deleted the fix-climing-warnings branch April 3, 2020 10:30
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
@vlvkobal @Saruspete
Fix compiler warnings in the claiming code (netdata#8567)
3f8058a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underhood underhood underhood approved these changes

@stelfrag stelfrag stelfrag approved these changes

@cosmix cosmix Awaiting requested review from cosmix

@ktsaou ktsaou Awaiting requested review from ktsaou

@amoss amoss Awaiting requested review from amoss

Assignees
No one assigned
Labels
area/build Build system (autotools and cmake). cloud Netdata hub/cloud related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlvkobal @underhood @stelfrag