Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for claiming k8s parent pods and Prometheus service discovery #10001

Merged
merged 5 commits into from Sep 30, 2020

Conversation

joelhans
Copy link
Contributor

@joelhans joelhans commented Sep 29, 2020

Summary

Fixes #8779

This PR improves our k8s documentation in two ways:

  1. Adds details on how to claim a k8s cluster's parent Netdata pod.
  2. Improves mentions of service discovery to include endpoints supported by the Prometheus collector.

Once this PR is merged, I'll add some additional text to the Helmchart repo with a link to the claiming process.

Component Name

area/docs

Test Plan

Tested and verified the claiming instructions on a k8s cluster.

Additional Information

@joelhans
Copy link
Contributor Author

@github-actions github-actions bot added area/docs area/packaging Packaging and operating systems support labels Sep 29, 2020
ilyam8
ilyam8 previously approved these changes Sep 29, 2020
knatsakis
knatsakis previously approved these changes Sep 29, 2020
@joelhans joelhans dismissed stale reviews from knatsakis and ilyam8 via 62ba9da September 29, 2020 14:59
packaging/installer/methods/kubernetes.md Outdated Show resolved Hide resolved
packaging/installer/methods/kubernetes.md Outdated Show resolved Hide resolved
@joelhans joelhans merged commit e788b1a into netdata:master Sep 30, 2020
@joelhans joelhans deleted the k8s-docs-sd branch September 30, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to claim nodes in Kubernetes
4 participants