Fix Docs GitHub Action with ignore list and update #10002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhans
added
the
no changelog
prologic
previously approved these changes
Sep 29, 2020
joelhans
changed the title
prologic
approved these changes
Oct 1, 2020
|
@Ferroin Mind looking at this? It would be nice to fix the Docs GHA so that we can more robustly ensure that we're not merging broken links into the docs. |
Ferroin
approved these changes
Nov 18, 2020
|
@joelhans Sorry about the delay in getting this approved, I seem to have missed it somehow... |
|
@Ferroin No worries! I forgot about it myself until I was tracking down some broken links yesterday. Looks like James' approval isn't valid any more, so we need one more. Have anyone in mind? |
|
At this point there really isn’t anyone else other than me, so I’ll just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've noticed that the Docs GitHub Action always fails due to failing to check the link
https://pi-hole.net. There's two problems with this. First, it shouldn't always be checking links in the Pi-hole guide—that's a bug. Second, the link is functional, so I'm choosing to ignore the failure.Component Name
area/ci
Test Plan
Additional Information