Claiming retry/backoff #10482
Merged
Claiming retry/backoff #10482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferroin
approved these changes
Jan 12, 2021
mfundul
approved these changes
Jan 12, 2021
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
Mar 17, 2021
* claiming retry/backoff logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to various network conditions claiming can fail. This is problem especially if run automatically trough Docker etc. where user just manually running script again is no go.
This implements retry independent of retry logic of wget/curl and common for them.
Me and bash are not best of friends :) so feel free to make alternative PR/proposal. This was supposed to quick & dirty do this for testing purposes.
Component Name
Claiming
Test Plan
Block port temporarily and then unblock it.
Additional Information