eBPF plugin remove parallel plugins #11287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/collectors
vlvkobal
suggested changes
Jun 29, 2021
vlvkobal
approved these changes
Jun 29, 2021
underhood
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After we have a short talk using Slack, I am bringing this PR to remove the possibility to have multiple eBPF plugins running in parallel.
I could not recreate the cited problem using kernel 5.12 many times, when the problem happened, it was thanks the fact I started another
netdatainstance beforeeBPF.pluginto be finished.Component Name
ebpf.plugin
Test Plan
1 - Compile this PR
2 - Start Netdata, take a look at new file
/usr/libexec/netdata/plugins.d/ebpf.d/ebpf.pid, it must have the currentPIDofebpf.plugin3 - Restart netdata and verify that you have only one
ebpf.pluginrunning and the PID was updated inside the file.Additional Information