Detect whether libatomic should be linked in when using CXX linker. #11818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already a check for this when building with the bundled protobuf. Considering that we needed the same check when building for ML, I moved the check so that it can happen in either case when a C++ linker is required for the build to succeed.
vkalintiris
requested review from
Ferroin,
iigorkarpov and
maneamarius
as code owners
underhood
previously approved these changes
Nov 22, 2021
iigorkarpov
previously approved these changes
Nov 22, 2021
|
@vkalintiris seems to break on CentOS7? |
IIUC,
TBH, I don't know what is the best approach here. |
vkalintiris
dismissed stale reviews from iigorkarpov and underhood
via
632fbda
underhood
reviewed
Nov 23, 2021
| # all the atomic ops with builtins then, the library will be left unused. | ||
| # Otherwise, some ops will be covered by the compiler's intrinsics and some | ||
| # will be picked up by the linker from -latomic. In the later case, if | ||
| # -latomic is not available there will be a build failure, which would |
There was a problem hiding this comment.
I think in future the correct way would be:
- detect if latomic is there
- detect if it is needed
if needed and not present then error in configure step with user friendly explanation to install libatomic instead of build failure
and in detect mode - disable all CXX features instead of failure
underhood
approved these changes
Nov 23, 2021
iigorkarpov
approved these changes
Nov 30, 2021
|
@stelfrag overview here:
|
|
Lets merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was already a check for this when building with the bundled
protobuf. Considering that we needed the same check when building for
ML, I moved the check so that it can happen in either case when a
C++ linker is required for the build to succeed.
Test Plan
CI jobs
Additional Information
This should fix #11812