Fix the code that checks for available updates. #11870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
stelfrag
reviewed
Dec 6, 2021
ilyam8
reviewed
Dec 6, 2021
ilyam8
reviewed
Dec 6, 2021
Ferroin
changed the title
Ferroin
requested review from
iigorkarpov,
maneamarius and
vkalintiris
as code owners
ilyam8
previously approved these changes
Dec 7, 2021
iigorkarpov
previously approved these changes
Dec 8, 2021
|
Good work, @Ferroin. I tested both compiled/static versions and both channels (stable, nightly) 👍 |
And use it to check for updates for static builds too.
This brings it into consistency with the existing install detection code in the new kickstart script, which correctly handles almost all cases of existing installs.
Ferroin
force-pushed
the
updater-check-fix
branch
from
fe4a6dc
to
6caf682
Compare
|
Rebased to pick up recent changes. |
ilyam8
reviewed
Dec 9, 2021
iigorkarpov
previously approved these changes
Dec 13, 2021
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
iigorkarpov
approved these changes
Dec 13, 2021
ilyam8
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the code responsible for checking for the availability of updates to the local copy of Netdata to correctly handle cases where the default install prefix is not used, as well as static installs.
This should prevent cases of the updater unconditionally running on some systems even if there is no available update.
Component Name
area/packaging
Test Plan
The simplest way to test this is to intentionally install an older static build and then run the updated version of the updater script from this PR against that install with the
--no-updater-self-updateoption.Additional Information
Fixes: #10555