Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal dbengine header from spawn/spawn_client.c #12009

Merged
merged 1 commit into from Jan 19, 2022
Merged

Remove internal dbengine header from spawn/spawn_client.c #12009

merged 1 commit into from Jan 19, 2022

Conversation

vkalintiris
Copy link
Contributor

Summary

Missed in #11967 due to the build system not being able to identify usage of undeclared headers (when building without dbengine).

Test Plan

Local build without dbengine & CI jobs.

underhood
underhood approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@underhood underhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local build with disabled dbengine worked fine

Features:
    dbengine:                   NO
    Native HTTPS:               YES
    Netdata Cloud:              YES 
    ACLK Next Generation:       YES
    ACLK-NG New Cloud Protocol: YES
    ACLK Legacy:                NO
    TLS Host Verification:      YES
    Machine Learning:           YES
    Stream Compression:         YES

thiagoftsm
thiagoftsm approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected, LGTM!

@vkalintiris vkalintiris merged commit a64dee4 into netdata:master Jan 19, 2022
@vkalintiris vkalintiris deleted the remove-unused-include branch January 19, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underhood underhood underhood approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

@erdem2000 erdem2000 Awaiting requested review from erdem2000

@MrZammler MrZammler Awaiting requested review from MrZammler

@stelfrag stelfrag Awaiting requested review from stelfrag

@Ferroin Ferroin Awaiting requested review from Ferroin Ferroin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vkalintiris @underhood @thiagoftsm