minor - remove ACLK_NEWARCH_DEVMODE #12018
Merged
+2
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underhood
requested review from
ilyam8,
MrZammler,
thiagoftsm and
vkalintiris
thiagoftsm
previously approved these changes
Jan 20, 2022
vkalintiris
previously approved these changes
Jan 21, 2022
stelfrag
previously approved these changes
Feb 23, 2022
underhood
dismissed stale reviews from stelfrag, vkalintiris, and thiagoftsm
via
581fc46
underhood
force-pushed
the
remove_newarch_devmode
branch
from
ebb9e3f
to
581fc46
Compare
|
rebased on latest master hoping to fix CI, no code changes |
stelfrag
approved these changes
Feb 23, 2022
ilyam8
approved these changes
Feb 23, 2022
thiagoftsm
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the ACLK_NEWARCH_DEVMODE to reduce the number of ifdefs. This is not needed anymore (was used in the initial new arch protocol development stages).
Test Plan
Code should not change any behavior in case ACLK_NEWARCH_DEVMODE is false
Additional Information