Overhaul handling of auto-updates in the installer code. #12076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
area/packaging
Ferroin
requested review from
DShreve2,
iigorkarpov,
kickoke,
maneamarius and
vkalintiris
as code owners
Ferroin
force-pushed
the
updater-install-handling
branch
from
e69ad29
to
b8cf500
Compare
|
Rebased to resolve merge conflict. |
kickoke
reviewed
Feb 4, 2022
Ferroin
force-pushed
the
updater-install-handling
branch
from
b8cf500
to
cfdbbb9
Compare
|
Rebased to resolve merge conflicts. |
Ferroin
force-pushed
the
updater-install-handling
branch
from
cfdbbb9
to
4f6bd5a
Compare
kickoke
previously approved these changes
Feb 9, 2022
Ferroin
force-pushed
the
updater-install-handling
branch
from
4f6bd5a
to
23dc231
Compare
|
Rebased to resolve merge conflicts. |
Ferroin
force-pushed
the
updater-install-handling
branch
from
23dc231
to
349d1b0
Compare
|
Rebased to resolve merge conflicts. |
maneamarius
previously approved these changes
Feb 17, 2022
|
Your shellcheck failed
|
Indeed, though it’s failing on unrelated code instead of on something I was actually changing, so I think it’s safe to ignore. |
Ferroin
force-pushed
the
updater-install-handling
branch
from
349d1b0
to
50de7b4
Compare
|
Rebased to resolve merge conflicts. |
marius-locomotion
previously approved these changes
Feb 18, 2022
kickoke
reviewed
Feb 18, 2022
| netdata -W buildinfo | grep 'Install type:' | ||
| ``` | ||
|
|
||
| If this produces no output, you have an older install and will have to manually look in the Netdata config directory. | ||
| If you are not sure where your Netdata config directory is, see the [configuration doc](/docs/configure/nodes.md). In | ||
| most installations, this is `/etc/netdata`. | ||
|
|
||
| Use `cd` to navigate to the Netdata config directory, then use `ls -a` to look for a file called `.install-type`. |
There was a problem hiding this comment.
@Ferroin Line 34 contains instructions but they are stuffed away in a paragraph.
Would you be fine to restructure the steps into an ordered list?
I proposed the following in the blog:
kickoke
reviewed
Feb 18, 2022
kickoke
previously approved these changes
Feb 18, 2022
maneamarius
previously approved these changes
Feb 18, 2022
This lets us handle the logic sanely from the kickstart script regardless of the install method, and allows users to more reliably toggle auto-updates themselves without having to understand what is being done.
Ferroin
dismissed stale reviews from maneamarius, kickoke, and marius-locomotion
via
3e8b61f
Ferroin
force-pushed
the
updater-install-handling
branch
from
50de7b4
to
3e8b61f
Compare
|
Rebased to fix merge conflicts. Also fixed doubled |
|
Merging this as the CI is passing and the only functional change since the last round of approvals is a documentation fix. |
Ferroin
added a commit
to Ferroin/netdata
that referenced
this pull request
Feb 19, 2022
…data#12076)" This reverts commit da7f215.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This completely overhauls how we are handling setup of auto-updates in the installer code. After this PR:
netdata-updater.shscript is properly bundled as part of our binary packages.netdata-updater.shscript can be used to toggle auto-updates on and off with new--enable-auto-updatesand--disable-auto-updatesoptions.netdata-installer.shor the static build installer code to do this.netdata-installer.shscript will not result in auto-updates being enabled (they did not always work correctly for this case as it was), though it will still install thenetdata-updater.shscript which can be used to manually enable auto-updates. The--auto-updateoption and associated other options will be silently ignored.netdata-updater.shscript which can be used to manually enable auto-updates. The--auto-updateoption will be silently ignored.Existing installs will be unaffected by these changes, other than native package-based installs properly including the updater script.
Test Plan
Basic handling of the new
--enable-auto-updatesand--disable-auto-updatesoptions can be done trivially on any existing static or locally built install by downloading the copy of the script from this PR and simply running it with the appropriate option.Testing of the kickstart changes will require an approach similar to our CI for testing the kickstart script against the code from the PR itself by using an override of the download URL for the source tarball.
Additional Information
Fixes: #12072