Fix compilation warnings on macOS #12082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
vlvkobal
force-pushed
the
fix-macos-warnings
branch
from
6219874
to
ab1fd55
Compare
vlvkobal
requested review from
stelfrag,
underhood and
vkalintiris
as code owners
thiagoftsm
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
I tested this PR on Slackware current, Manjaro 21.1, and `FreeBSD 13.0-RELEASE-p7'. I did not observe any warning related to these features and everything worked as expected.
I have to call attention for the fact that I do not have Mac to test it, so another person will need to test this PR on this environment.
underhood
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
when built on m1 mac those warnings are not there. We have another warnings though in case it is used with openssl 3 (usage of functions that are going to be deprecated in openssl3)
tested on:
sw_vers
ProductName: macOS
ProductVersion: 12.0.1
BuildVersion: 21A559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SSIA
Test Plan
There should not be any compilation warnings on macOS.