Add proper support for Oracle Linux native packages to installer. #12101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
area/packaging
They got missed somehow in the initial implementation.
Ferroin
force-pushed
the
kickstart-ol8
branch
from
9e29e4d
to
e123599
Compare
|
Rebased to resolve merge conflicts. |
maneamarius
approved these changes
Feb 10, 2022
Ferroin
requested review from
DShreve2,
kickoke and
vkalintiris
as code owners
iigorkarpov
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
They got missed somehow in the initial implementation.
Also fixes a potential bug in version parsing for CentOS systems.
Test Plan
Once #12100 is merged and the repoconfig packages are updated, this can be tested by simply running the updated
kickstart.shfrom this PR in an OL8 Docker container. Without the changes here, it will fall back to a static install. With these changes, it will instead install using a native package.