Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make netdata-uninstaller.sh POSIX compatibility and add --uninstall flag… #12195

Merged

Conversation

maneamarius
Copy link
Contributor

… in kickstart.sh

Summary
Test Plan
Additional Information

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Feb 21, 2022
iigorkarpov
iigorkarpov previously approved these changes Feb 21, 2022
Copy link
Contributor

@iigorkarpov iigorkarpov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maneamarius maneamarius marked this pull request as ready for review February 21, 2022 09:38
packaging/installer/netdata-uninstaller.sh Outdated Show resolved Hide resolved
packaging/installer/netdata-uninstaller.sh Outdated Show resolved Hide resolved
packaging/installer/netdata-uninstaller.sh Outdated Show resolved Hide resolved
packaging/installer/netdata-uninstaller.sh Outdated Show resolved Hide resolved
packaging/installer/netdata-uninstaller.sh Outdated Show resolved Hide resolved
iigorkarpov
iigorkarpov previously approved these changes Feb 28, 2022
Copy link
Member

@Ferroin Ferroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the single comment I left.

packaging/installer/kickstart.sh Outdated Show resolved Hide resolved
@maneamarius maneamarius merged commit 61681f7 into netdata:master Mar 1, 2022
@maneamarius maneamarius deleted the POSIX-uninstaller-and-uninstall-flag branch March 10, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants