Fix hpssa parse error
#12206
Merged
Fix hpssa parse error
#12206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line with `Disk Partition Information` generates parser error. As such lines includes not used information this patch simply excludes them.
|
|
github-actions
bot
added
area/collectors
|
Sorry... was too fast with first commit ... :| |
|
Hi, @wooyey. Thanks for the contribution. Did you test the change on servers with and without that line? |
|
Hey @ilyam8 :) Code (the second commit) was tested on:
In both cases the collector is working correctly. In second case produced data is the same as for old version of code. |
ilyam8
approved these changes
Feb 21, 2022
thiagoftsm
approved these changes
Feb 22, 2022
vlvkobal
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12205. Line with
Disk Partition Informationgenerates parser error of thehpssacollector.As such lines includes not useful information this patch simply excludes them.
Test Plan
Just tested manually by me on failing system, where it works.
On other HP servers where setup is very similar didn't found this issue (no problematic line in
ssaclioutput).So the issue might be quite unique...
Grepping through the repo show no tests of
hpssacollector.Additional Information