Fix node information send to the cloud for older agent versions #12223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelfrag
requested review from
erdem2000 and
odynik
and removed request for
vkalintiris and
thiagoftsm
|
Tested this on a setup with older children and it seems working. Does not crash now. |
underhood
reviewed
Feb 23, 2022
underhood
approved these changes
Feb 24, 2022
MrZammler
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes netdata/netdata-cloud#293
Summary
In a child - parent setup when an child is running a very old agent version it doesn't send information that the
parent running a newer version expects.
If the parent is claimed and connected to the cloud, it will attempt to build a node info payload and it will crash.
This PR adds checks for
Test Plan