Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix kickstart syntax #12228

Closed
wants to merge 3 commits into from
Closed

Docs: Fix kickstart syntax #12228

wants to merge 3 commits into from

Conversation

kickoke
Copy link
Contributor

@kickoke kickoke commented Feb 23, 2022

Problem

-token=TOKEN is not the correct syntax for the kickstart script.
-token TOKEN is correct.

Solution

Removed = where it would mess up the kickstart script.

Removed `=` where it would mess up the kickstart script.
@Ferroin
Copy link
Member

Ferroin commented Feb 23, 2022

The particular cases here actually have nothing to do with the kickstart script itself, and any of the cases that involve netdata-claim.sh actually need the = instead of a space.

I’m not sure about the -W claim stuff though, but I think it also needs the = instead of spaces as well.

@ilyam8
Copy link
Member

ilyam8 commented Feb 23, 2022

I’m not sure about the -W claim stuff though, but I think it also needs the = instead of spaces as well.

From the old helmchart release

              -W set2 cloud global enabled true
              -W set2 cloud global "cloud base url" "{{ .url }}"
              -W "claim -token={{ .token }} -rooms={{ .rooms }} -url={{ .url }}"

claim/README.md Outdated Show resolved Hide resolved
claim/README.md Outdated Show resolved Hide resolved
claim/README.md Outdated Show resolved Hide resolved
@ilyam8
Copy link
Member

ilyam8 commented Mar 2, 2022

The OP is correct, but all the changes are netdata-claim.sh changes (not kickstart.sh). The netdata-claim.sh script syntax is key=value (as @Ferroin correctly mentioned).

for arg in "$@"
do
case $arg in
-token=*) TOKEN=${arg:7} ;;
-url=*) [ -n "${arg:5}" ] && URL_BASE=${arg:5} ;;
-id=*) ID=${arg:4} ;;
-rooms=*) ROOMS=${arg:7} ;;

This PR is wontfix.

@ilyam8 ilyam8 closed this Mar 2, 2022
@ilyam8 ilyam8 deleted the kickoke-kickstart-docs branch May 16, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants