Fix builds where HAVE_C___ATOMIC is not defined. #12240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkalintiris
requested review from
MrZammler,
stelfrag,
underhood and
erdem2000
erdem2000
approved these changes
Feb 24, 2022
stelfrag
approved these changes
Feb 24, 2022
underhood
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build/m4/ax_c___atomic.m4wrongly skips setting HAVE_C___ATOMIC on some 32-bit platforms.This breaks C++ 11 code because of the definition of
rrdset_flag_set.Test Plan
CI jobs & local builds after undef-ing the aforementioned macro.