Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fix to correctly register child nodes to the cloud via a parent #12241

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Feb 24, 2022

Summary

Children with agent versions before v1.31 will not register correctly to their claimed parent so that they can be announced
to the cloud.

This PR adds the missing information to properly register the children to the cloud via the parent by enabling a trigger to store the information in the node instance table whenever a host is created

Test Plan
  • Parent agent running the latest version and claimed to the cloud
  • Child running any pre 1.31 version (not claimed to the cloud)
    • The child will not register properly to the cloud

After the PR

  • The child will register properly to the cloud

  This will allow older agent versions pre v1.31 to connect to the cloud via the parent
@ktsaou ktsaou merged commit 44c6382 into netdata:master Feb 25, 2022
@stelfrag stelfrag deleted the 0populate_node_instance branch February 25, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants