Timex: make offset rrd independently configurable #12281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset rrd did not use the do_offset boolean but would re-use the do_sync boolean.
|
|
github-actions
bot
added
the
area/collectors
ilyam8
approved these changes
Mar 1, 2022
|
Thanks for the fix, @d--j 👍
Indeed, I think we missed that because it was spotted after the merge. |
surajnpn
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset rrd did not use the
do_offsetboolean but would re-use thedo_syncboolean. This looks like an oversight/copy&paste error and this very simple pull request just corrects this typo.I just stumbled upon this by accident and did not bother enough to get to know your test suite/write tests for this PR. Feel free to discard this PR when you will not accept PRs without tests.
Looks like @vkalintiris spotted this in the initial PR, too but there was no answer/action on his remark: https://github.com/netdata/netdata/pull/10895/files#r632975566