Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kickstart): use correct syntax for claiming extra parameters #12289

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Mar 2, 2022

Summary

id, proxy, user and hostname claiming parameters syntax is key=value, not key[space]value.

for arg in "$@"
do
case $arg in
-token=*) TOKEN=${arg:7} ;;
-url=*) [ -n "${arg:5}" ] && URL_BASE=${arg:5} ;;
-id=*) ID=${arg:4} ;;
-rooms=*) ROOMS=${arg:7} ;;
-hostname=*) HOSTNAME=${arg:10} ;;
-verbose) VERBOSE=1 ;;
-insecure) INSECURE=1 ;;
-proxy=*) PROXY=${arg:7} ;;
-noproxy) NOPROXY=yes ;;
-noreload) RELOAD=0 ;;
-user=*) NETDATA_USER=${arg:6} ;;

Test Plan

Tested by @erdem2000

Additional Information

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Mar 2, 2022
@ilyam8 ilyam8 merged commit aed4ee7 into netdata:master Mar 2, 2022
@ilyam8 ilyam8 deleted the fix_kickstart_claim_extra_params branch March 2, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants