Fix handling of checks for newer updater script on update. #12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Properly handle GitHub’s brain-dead error responses. * Fix parsing of dates on BSD and macOS systems. * Make the timestamp conversion more robust.
ilyam8
reviewed
Mar 10, 2022
github-actions
bot
added
the
area/packaging
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
ilyam8
reviewed
Mar 10, 2022
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
ilyam8
reviewed
Mar 11, 2022
ilyam8
reviewed
Mar 11, 2022
ilyam8
approved these changes
Mar 11, 2022
maneamarius
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
This can be tested by simply running the updater script from this PR locally. However, due to the nature of API failures, the first case can only be properly tested in a probabilistic manner.
Additional Information
Fixes: #12364