Delay removed event for 60 seconds after the chart's last collected time #12388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrZammler
requested review from
thiagoftsm,
vlvkobal and
vkalintiris
as code owners
MrZammler
requested review from
thiagoftsm
and removed request for
vkalintiris and
thiagoftsm
vlvkobal
previously approved these changes
Mar 14, 2022
stelfrag
previously approved these changes
Mar 14, 2022
erdem2000
previously approved these changes
Mar 14, 2022
vkalintiris
reviewed
Mar 14, 2022
stelfrag
approved these changes
Mar 14, 2022
vlvkobal
approved these changes
Mar 14, 2022
vkalintiris
approved these changes
Mar 14, 2022
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a delay before creating a REMOVED alert event when a chart goes obsolete. It should help with cases when charts go in OBSOLETE and then back to ok quickly.
Test Plan
Similar testing can be conducted as in #12021 (using e.g. a usb stick). This time around, with this PR, the REMOVED event should be produced 60 seconds after the last_collected time.