Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove "web files" options leftovers #12403

Merged
merged 7 commits into from
Mar 15, 2022

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Mar 14, 2022

Summary

Should have been removed in #12339, but managed to survive 馃槃

@thiagoftsm @vlvkobal there are 2 more lines

web/api/tests/valid_urls.c:78:    if (!strcmp(section, CONFIG_SECTION_WEB) && !strcmp(name, "web files owner"))
web/api/tests/web_api.c:78:    if (!strcmp(section, CONFIG_SECTION_WEB) && !strcmp(name, "web files owner"))

If it is easy to remove and you think it is worth time (probably not), feel free to push additional commits in this branch.

Test Plan

Not needed

Additional Information

thiagoftsm
thiagoftsm previously approved these changes Mar 14, 2022
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Mar 14, 2022
@@ -1,9 +1,6 @@
--- system/netdata.conf.orig 2018-05-10 19:44:49.000000000 +0300
+++ system/netdata.conf 2018-05-10 19:45:14.000000000 +0300
@@ -22,3 +22,7 @@
[web]
web files owner = root
web files group = netdata
+
+[health]
+ # script for sles 11, mail notifications only
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is likely wrong and I need properly to regenerate the patch @Ferroin, correct? If so I just undo the commit 馃槃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLES 11 is EOL. Maybe we just remove the patches, @Ferroin?

vlvkobal
vlvkobal previously approved these changes Mar 15, 2022
@ilyam8 ilyam8 requested a review from thiagoftsm March 15, 2022 10:58
thiagoftsm
thiagoftsm previously approved these changes Mar 15, 2022
@ilyam8 ilyam8 requested a review from thiagoftsm March 15, 2022 12:36
@ilyam8 ilyam8 merged commit c05d44f into netdata:master Mar 15, 2022
@ilyam8 ilyam8 deleted the remove_web_files_options_leftovers branch March 15, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon area/docs area/packaging Packaging and operating systems support area/web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants