Add support for passing extra claiming options when claiming with Docker. #12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
Ferroin
changed the title
ilyam8
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
LGTM but updating https://learn.netdata.cloud/docs/agent/claim#using-environment-variables would make this PR even more awesome
stelfrag
approved these changes
Mar 30, 2022
maneamarius
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new environment variable to our entrypoint script named
NETDATA_EXTRA_CLAIM_OPTS. The contents of this variable will be passed directly (with word splitting) to the claiming script if it is invoked by the Docker entrypoint, allowing passing of arbitrary additional options.Test Plan
A simple test with a locally built Docker image can be done by adding
-e NETDATA_EXTRA_CLAIM_OPTS=-verboseto the options passed todocker runwhen creating the image.Without the changes in this PR, the claiming process should produce it’s normal terse output.
With the changes in this PR, the claiming process should produce verbose output.