Implement fine-grained errors to cloud queries #12460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underhood
changed the title
stelfrag
reviewed
Mar 18, 2022
stelfrag
reviewed
Mar 20, 2022
MrZammler
reviewed
Mar 21, 2022
| retval = 1; | ||
| w->response.code = 404; | ||
| aclk_http_msg_v2_err(query_thr->client, query->callback_topic, query->msg_id, w->response.code, NULL, 0); | ||
| aclk_http_msg_v2_err(query_thr->client, query->callback_topic, query->msg_id, w->response.code, CLOUD_EC_MALFORMED_NODE_ID, CLOUD_EMSG_MALFORMED_NODE_ID, NULL, 0); |
There was a problem hiding this comment.
Hi! Not specific to this PR, but maybe there could be another response than 404 to indicate this? I know cloud must already be consuming this, but maybe as an enhancement.
There was a problem hiding this comment.
Yeah should be easier to change this in future after cloud consumes the new custom error codes -> so they can match it whenif we change from 404
MrZammler
approved these changes
Mar 21, 2022
stelfrag
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #12340
Test Plan
See the generated message. Cloud hasn't implemented this yet but we got green light to send this (Cloud should for now ignore until they find time to implement) but should not cause errors on cloud.
Additional Information