Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collectors/cgroups): prefer blkio.*_recursive when available #12462

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Mar 19, 2022

Summary

Fixes: #12434

After this PR cgroups.plugin will prefer blkio.*_recursive when collecting disk family stats.

blkio.*_recursive
Recursive version of various stats. These files show the
same information as their non-recursive counterparts but
include stats from all the descendant cgroups.

Test Plan

Will be tested by @ktsaou

Additional Information

@ilyam8 ilyam8 marked this pull request as ready for review March 21, 2022 07:21
@ilyam8 ilyam8 requested a review from vlvkobal as a code owner March 21, 2022 07:21
@ktsaou
Copy link
Member

ktsaou commented Mar 21, 2022

It works!

@ilyam8 ilyam8 merged commit d40b5cb into netdata:master Mar 21, 2022
@ilyam8 ilyam8 deleted the prefer_cgroup_blkio_recursive branch March 21, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: libvirt VMs are monitored twice
4 participants