Properly recognize Almalinux as an RHEL clone. #12487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
|
I was testing your PR on /etc/os-release information:
NAME : AlmaLinux
VERSION : 8.5 (Arctic Sphynx)
ID : almalinux
ID_LIKE : rhel centos fedora
VERSION_ID : 8.5
We detected these:
Distribution : almalinux
Version : 8.5
Codename : 8.5 (Arctic Sphynx)
Package Manager : install_yum
Packages Tree : centos
Detection Method: /etc/os-release
Default Python v: 3
./packaging/installer/install-required-packages.sh: line 2220: syntax error near unexpected token `<'
./packaging/installer/install-required-packages.sh: line 2220: `mapfile -t PACKAGES_TO_INSTALL < <(packages | sort -u)' |
|
@thiagoftsm I’m unable to replicate this issue when testing either in Docker, or in an Alma Linux VPS I spun up specifically for testing this code, but I also don’t have access to a system running Vagrant to test there. I suspect that you will see the same error without these changes in that environment. |
|
I am getting... |
This should make things behave more correctly.
|
@thiagoftsm @stelfrag Can you retest with the changes I just pushed? And, if you still see the same issues, please share the |
thiagoftsm
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
After last commit, the script ran without errors on my host:
/etc/os-release information:
NAME : AlmaLinux
VERSION : 8.5 (Arctic Sphynx)
ID : almalinux
ID_LIKE : rhel centos fedora
VERSION_ID : 8.5
We detected these:
Distribution : almalinux
Version : 8.5
Codename : 8.5 (Arctic Sphynx)
Package Manager : install_dnf
Packages Tree : centos
Detection Method: /etc/os-release
Default Python v: 3
LGTM!
maneamarius
pushed a commit
to maneamarius/netdata
that referenced
this pull request
Apr 4, 2022
* Properly recognize Almalinux as an RHEL clone. * Prefer DNF over YUM when available. This should make things behave more correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SSIA
Test Plan
This can be tested using an Alma Linux Docker container.
Additional Information
Fixes: #12486