fix(netdata-updater): properly handle update for debian packages

[ilyam8]

Summary

Fixes: #12525

This PR:

• removes [ "${INSTALL_UID}" != "$(id -u)" ] check for binpkg packages (we don't create .environment file for deb).
• changes pkg_installed_check from dpkg -l to dpkg -s, because -l doesn't really work

dpkg -l

# no netdata pacages intalled
ilyam@deb-fra1-01:~$ dpkg -l | grep netdata

# install netdata-repo-edge
ilyam@deb-fra1-01:~$ sudo apt-get install netdata-repo-edge >/dev/null


# problem, for some reason there is 'netdata-repo' but 'un' - uknown/not-intalled
ilyam@deb-fra1-01:~$ dpkg -l netdata-repo && echo $?
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
un  netdata-repo   <none>       <none>       (no description available)
0


ilyam@deb-fra1-01:~$ dpkg -l netdata-repo-edge && echo $?
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name              Version      Architecture Description
+++-=================-============-============-===============================================================
ii  netdata-repo-edge 1-1          all          Configuration for the official Netdata Edge package repository.
0

dpkg -s

ilyam@deb-fra1-01:~$ dpkg -l | grep netdata
ii  netdata-repo-edge                                1-1                            all          Configuration for the official Netdata Edge package repository.

ilyam@deb-fra1-01:~$ dpkg -s netdata-repo > /dev/null 2>&1; echo $?
1

ilyam@deb-fra1-01:~$ dpkg -s netdata-repo-edge > /dev/null 2>&1; echo $?
0

Test Plan

• install Netdata Debian package, execute the update script.

Additional Information

For users: How does this change affect me?

[ilyam8]

I think this check is disconnected from the fatal message, perhaps we need just to check [ $(id -u) != "0" ] here.

[netdata-community-bot]

This pull request has been mentioned on Netdata Forums. There might be relevant details there:

https://community.netdata.cloud/t/claim-fails-with-error-failed-to-update-netdata-you-are-running-this-script-as-user-with-uid-0-we-recommend-to-run-this-script-as-root-user-with-uid-0/2703/5

[netdata-community-bot]

This pull request has been mentioned on Netdata Forums. There might be relevant details there:

https://community.netdata.cloud/t/i-have-problem-when-i-update-new-code-update/2721/2