Fix CodeClimate ESLint warnings #12546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bit at a loss as to why my changes result in these complexity issues. I haven't dealt with such issues before unfortunately :( Would it be possible to get some help on this point? :) |
|
Not applicable anymore. If there are any suggested changes to the dashboard code - should be a PR in https://github.com/netdata/dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests fixes most of the ESLint warnings generated on CodeClimate.
I might have missed a few, but most should be solved now.
Test Plan
Tried to find as many of the uses of these JavaScript files in the project as possible, where I tested the behavior of the function before and after the made changes. I couldn't find all though, but the changes are so minor that I don't forsee any issues.
Additional Information
I made these changes in favor of improving the code quality of Netdata even further.
It are mostly minor changes, like removing a trailing comma.