Don't send alert events without wc->host #12547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelfrag
reviewed
Mar 29, 2022
stelfrag
approved these changes
Mar 30, 2022
underhood
approved these changes
Mar 30, 2022
maneamarius
pushed a commit
to maneamarius/netdata
that referenced
this pull request
Apr 4, 2022
* if wc->host is null dont send events * we will always have wc->host * free claim_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't try to send alert events if
wc->hostis not yet connected. If that happens, it is better to wait for the next iteration of the function (when eventuallywc->hostwill be ok... ?) instead of sending an event with missing timezone data.Fixes #12539
Test Plan
Since it's hard to reproduce, basic testing of alerts still going to the cloud after this change should be ok.
Additional Information