New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory CO-RE #12684
Memory CO-RE #12684
Conversation
09993d5
to
3a77d41
Compare
3a77d41
to
8270668
Compare
|
@@ -1002,8 +1296,9 @@ void *ebpf_cachestat_thread(void *ptr) | |||
cachestat_counter_dimension_name, cachestat_counter_dimension_name, | |||
algorithms, NETDATA_CACHESTAT_END); | |||
|
|||
pthread_mutex_lock(&lock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, do you plan to use libuv threading and synchronization primitives in the eBPF plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was fixed with last commit, thanks to report! |
Summary
This PR is adding
CO-RE
algorithms to all threads related to memory actions.We are also doing small changes in
directory cache
andcachestat
to speed up the thread loading.When I was developing this PR, the logic for commits was (exceptions can happen):
Commits
Test Plan
/etc/netdata/ebpf.d.conf
to:Script:
Additional Information
On Slackware I am not adding any
cgroup
chart, because Slackware does not havesystemd
( 🥳 ).You can get all reports using this link.
This PR was already tested on:
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? Dashboard, and performance. - Can they see the change or is it an under the hood? If they can see it, where? This is not visible for users, because we are changing the way we collect data. - How is the user impacted by the change? Performance. - What are there any benefits of the change? Charts used to monitor SWAP, Cachestat, and Directory cache will affect less the host, because users will use `trampolines` instead `kprobes`